Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save As with validation errors changes view name without saving #22

Open
bhp1 opened this issue May 26, 2015 · 4 comments
Open

Save As with validation errors changes view name without saving #22

bhp1 opened this issue May 26, 2015 · 4 comments
Assignees
Labels

Comments

@bhp1
Copy link
Collaborator

bhp1 commented May 26, 2015

If an instrument or tuning has validation errors, using "Save As" with a new name will change the name on the view tab, even though the data wasn't saved. When the user closes the view (or the whole application), they get a "file save" warning, even if "warn on dirty close" is not set.

@bhp1 bhp1 added the bug label May 26, 2015
bhp1 added a commit that referenced this issue May 26, 2015
reason triggers the "file save" warning when data model is closed.
@bhp1
Copy link
Collaborator Author

bhp1 commented May 26, 2015

This behaviour is buried in the application framework. Overriding saveData in WIDesigner class, or catching dataModelSaving in the DataModelAdapter, are not sufficient to avoid the change of name.

@bhp1
Copy link
Collaborator Author

bhp1 commented May 26, 2015

Removal of dataModel.isDirty() call from dataModelClosing appears to get rid of the "file save" warning whether or not "warn on dirty close" is set. Under the circumstances of this issue, the call returned false, so the setDirty(false) call was skipped.
"File save" warning fixed for release 1.0.5.
(This does not address the change of name in the view tab.)

@edwardkort edwardkort self-assigned this May 28, 2015
@edwardkort
Copy link
Owner

There is a bug in JDAF. When I get a fix or workaround, I will fix this.

@edwardkort
Copy link
Owner

As of 1/31/2017 JideSoft said that this bug will not be fixed: it requires too big a change in the JDAF architecture. This will remain a known issue unless we want to build our own validation framework. However, since we do very little XML hand editing any more, this issue IMHO is not a very high priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants