Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark is flawed #5

Closed
maroux opened this issue Apr 23, 2022 · 3 comments · Fixed by #73
Closed

Update benchmark is flawed #5

maroux opened this issue Apr 23, 2022 · 3 comments · Fixed by #73
Labels
bug Something isn't working

Comments

@maroux
Copy link

maroux commented Apr 23, 2022

Since Insert doesn't check for created Id for raw and ent, the inserted model's id is 0 and hence the subsequence update doesn't affect any rows, and hence the code if flawed.

@efectn efectn added the bug Something isn't working label Apr 23, 2022
@efectn
Copy link
Owner

efectn commented Apr 23, 2022

You're right. Update results are flawed. If you are free, can you send a PR? I'll be busy with other tasks for 3-4 days @maroux

@maroux
Copy link
Author

maroux commented Apr 23, 2022

Additionally, I don't know why testing.B code is duplicated here instead of just using go test -bench :/

@efectn
Copy link
Owner

efectn commented Apr 23, 2022

Additionally, I don't know why testing.B code is duplicated here instead of just using go test -bench :/

I'll change benchmark suite by testing.Benchmark() on next week. I have a design in my mind.

maroux added a commit to maroux/go-orm-benchmarks that referenced this issue Apr 24, 2022
@efectn efectn linked a pull request Jun 22, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants