Parsing comments inside an array in an Option

[patdimond]

I have some proto that looks like this

syntax = "proto3";

package test.service.test.alpha;

service MyTestService {

  rpc MyTestRPC(input) returns (output) {

    option test = {
      scope_rules : [
        // A comment
        {has : [ "test" ]}
      ]
    };
  }
}

Which causes the parser to throw this error: Error: <input>:12:9: found "{" but expected [, or ]]

I got a hacky fix to work and pass tests by adding the following lines in option.go after the check for a closing bracket ]
https://github.com/emicklei/proto/blob/master/option.go#L201-L207

		// if it's a comment, consume it
		if '/' == r {
			p.next()
		}

but then realised that would only work for a single comment.
I'm unsure what an appropriate fix is here so figured I'd raise an issue. Thanks.

Sidenote - It seems to work properly if the comment appears after the {

    option test = {
      scope_rules : [ {
        // A comment
        has : [ "test" ]
      } ]
    };

[emicklei]

thank you for reporting this issue. I am aware that comment parsing is not implemented at all possible locations. I will have a look if this case can be supported

[emicklei]

adding test to reproduce

func TestCommentInsideArray(t *testing.T) {
	src := `option test = {
			scope_rules : [
			  // A comment
			  // Another comment
			  {has : [ 
				// comment on test
				"test" 
			  ]}
			]
		  };
		`
	opt, err := newParserOn(src).Parse()
	if err != nil {
		t.Fatal(err)
	}
	opt2 := opt.Elements[0].(*Option)
	scp, _ := opt2.Constant.OrderedMap.Get("scope_rules")
	elem0 := scp.Array[0]
	t.Log("comment:", elem0.InlineComment.Lines)
	has, _ := elem0.OrderedMap.Get("has")
	if got, want := has.Array[0].Source, "test"; got != want {
		t.Errorf("got [%v:%T] want [%v:%T]", got, got, want, want)
	}
	t.Log("comment:", has.Array[0].InlineComment.Lines)
}

[emicklei]

check #139

[patdimond]

Works for me. Thanks!