Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parent Visitee to key Visitees (Option, EnumField, etc)? #25

Closed
bufdev opened this issue Dec 6, 2017 · 1 comment
Closed

Add Parent Visitee to key Visitees (Option, EnumField, etc)? #25

bufdev opened this issue Dec 6, 2017 · 1 comment

Comments

@bufdev
Copy link
Contributor

bufdev commented Dec 6, 2017

For Option specifically, if I'm writing a formatter, I need to know what type of option it is (message option, rpc method option, etc). I could have a completely new visitor for this but this seems overkill.

@bufdev
Copy link
Contributor Author

bufdev commented Dec 7, 2017

This can be mitigated by having a parent Visitee field in the struct that implements Visitor:

func (v *logVisitor) VisitEnum(element *proto.Enum) {
	v.logVisitee(element)
	originalParent := v.parent
	v.parent = element
	for _, child := range element.Elements {
		child.Accept(v)
	}
	v.parent = originalParent
}

@bufdev bufdev closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant