Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of antisense chains in sequence mode #6252

Closed
ljubica-milovic opened this issue Jan 10, 2025 · 0 comments · Fixed by #6516
Closed

Allow creation of antisense chains in sequence mode #6252

ljubica-milovic opened this issue Jan 10, 2025 · 0 comments · Fixed by #6516
Assignees
Labels
Antisense Bucket: Antisense related issues Hydrogen bonds Bucket: Bugs related to Hydrogen bonds Sequence mode Bucket: Sequence mode related issues Test Cases Written Test cases has been written for that issue

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Jan 10, 2025

Background

This ticket covers the creation of antisense chains in sequence mode.
Layout/representation of antisense chains in sequence mode is covered in the following ticket: #5942.

Requirements

  1. When appropriate monomers are selected right-clicking on the monomers should give a drop-down menu with the options of "Create RNA Antisense Strand" and "Create DNA Antisense Strand".

Appropriate selection described in ticket #5678.

1.1. When appropriate monomers are selected the "Create Antisense Strand" (issue: #5999) tool should be enabled.

1.2. If the selection of monomers in not appropriate the option in the drop-down menu, as well as the tool should be disabled.


2.1. When "Create RNA/DNA Antisense Strand" is chosen from the drop-down menu or the "Create Antisense Strand" tool is used, the logic for creating the antisense chain in the same as for other modes, and already described in #5678 (requirements 2) for RNA and in #6383 for DNA.

2.2. Antisense and sense chains should be layouted following the logic described in #5942 (requirements 2 & 3).

2.3. If no other double-stranded sequences existed on the canvas before the creation of the new antisense chain, the sync icon should appear on the top bar and be enabled/toggled on by default #6254 (requirement 4).

UX

Image

@ljubica-milovic ljubica-milovic added feature request Sequence mode Bucket: Sequence mode related issues Hydrogen bonds Bucket: Bugs related to Hydrogen bonds labels Jan 10, 2025
@ljubica-milovic ljubica-milovic changed the title Allow creation of antisense chains in sequence mode Allow creation of antisense chains in sequence mode (1/2) Jan 10, 2025
@ljubica-milovic ljubica-milovic changed the title Allow creation of antisense chains in sequence mode (1/2) Allow creation of antisense chains in sequence mode Jan 10, 2025
@AlexeyGirin AlexeyGirin added the Antisense Bucket: Antisense related issues label Jan 24, 2025
@ljubica-milovic ljubica-milovic added this to the Ketcher 3.2.0-rc.1 milestone Jan 29, 2025
@NataliaLoginova NataliaLoginova self-assigned this Jan 30, 2025
@vitaepam vitaepam self-assigned this Feb 13, 2025
@vitaepam vitaepam linked a pull request Feb 14, 2025 that will close this issue
9 tasks
@NataliaLoginova NataliaLoginova removed their assignment Feb 14, 2025
@Zhirnoff Zhirnoff added the Test Cases Written Test cases has been written for that issue label Feb 19, 2025
rrodionov91 added a commit that referenced this issue Feb 19, 2025
* feat: Add antisense logic in menu dropdown

* feat: Reuse antisense logic in menu dropdown from other view

* feat: Update rerender for sequence mode

* feat: Update Playwright tests

* feat: Update Playwright test

* - updated screenshots

---------

Co-authored-by: Roman Rodionov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Antisense Bucket: Antisense related issues Hydrogen bonds Bucket: Bugs related to Hydrogen bonds Sequence mode Bucket: Sequence mode related issues Test Cases Written Test cases has been written for that issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants