Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanded macromolecules in Micro Mode causes unintended merging #6556

Closed
Zhirnoff opened this issue Feb 21, 2025 · 1 comment · Fixed by #6564, #6567 or #6568
Closed

Expanded macromolecules in Micro Mode causes unintended merging #6556

Zhirnoff opened this issue Feb 21, 2025 · 1 comment · Fixed by #6564, #6567 or #6568
Labels
Macro-Micro Bucket: Macro-Micro View related issues Priority: High Severity: High High level visibility to the user User`s Feedback
Milestone
Ketcher 3.0.2

Comments

@Zhirnoff
Copy link
Collaborator

Description
When using the Expand in Micro mode for Macromolecules, the expanded structures should remain separate. However, if multiple macromolecules are expanded or rotated close to each other, they incorrectly merge instead of staying as distinct entities. In such cases, an Edit Abbreviation dialog should appear, but it does not.

Steps to Reproduce

  1. Add any macromolecules in Macro mode
  2. Switch to Micro mode
  3. Expand all macromolecules and rotate close to each other

Actual behavior
The expanded macromolecules merge unintentionally.
No Edit Abbreviation dialog appears to confirm or prevent merging.

Expected behavior
Each expanded macromolecule should remain a separate entity.
If an attempt is made to merge them, the Edit Abbreviation dialog should appear.

Screenshots

Image
Image

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 131.0.6778.205 (Official Build) (64-bit)

Ketcher version
[Version 3.1.0-rc.4]
Indigo version
[Version 1.29.0-rc.1]
@Zhirnoff Zhirnoff added Macro-Micro Bucket: Macro-Micro View related issues Priority: High Severity: High High level visibility to the user User`s Feedback labels Feb 21, 2025
@Zhirnoff Zhirnoff added this to the Ketcher 3.0.2 milestone Feb 21, 2025
KonstantinEpam23 pushed a commit that referenced this issue Feb 25, 2025
@KonstantinEpam
#6556 - Expanded macromolecules in Micro Mode causes unintended merging
497360a
@KonstantinEpam23 KonstantinEpam23 linked a pull request Feb 25, 2025 that will close this issue
#6556 - Expanded macromolecules in Micro Mode causes unintended merging #6564
Merged
9 tasks
KonstantinEpam23 pushed a commit that referenced this issue Feb 25, 2025
@KonstantinEpam
#6556 - Expanded macromolecules in Micro Mode causes unintended merging
4570fc3
@KonstantinEpam23
Copy link
Collaborator

Fixed in: #6564
Please note, the fix does not include showing the "remove abbreviation" functionality

KonstantinEpam23 pushed a commit that referenced this issue Feb 25, 2025
@KonstantinEpam
#6556 - Expanded macromolecules in Micro Mode causes unintended merging
5e29b04
@KonstantinEpam23 KonstantinEpam23 linked a pull request Feb 25, 2025 that will close this issue
Backmerge: #6556 - Expanded macromolecules in Micro Mode causes unintended merging #6567
Merged
9 tasks
KonstantinEpam23 pushed a commit that referenced this issue Feb 25, 2025
@KonstantinEpam
#6556 - Expanded macromolecules in Micro Mode causes unintended merging
90949ad
rrodionov91 pushed a commit that referenced this issue Feb 25, 2025
@KonstantinEpam23 @KonstantinEpam
#6556 - Expanded macromolecules in Micro Mode causes unintended mergi…
fa9a700 
…ng (#6564)

Co-authored-by: Konstantin Levin <[email protected]>
@KonstantinEpam23 KonstantinEpam23 linked a pull request Feb 25, 2025 that will close this issue
Backmerge [3.1]: #6556 - Expanded macromolecules in Micro Mode causes unintended merging #6568
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Feb 25, 2025
@KonstantinEpam23 @KonstantinEpam
#6556 - Expanded macromolecules in Micro Mode causes unintended mergi…
308845f 
…ng (#6568)

Co-authored-by: Konstantin Levin <[email protected]>
rrodionov91 pushed a commit that referenced this issue Feb 25, 2025
@KonstantinEpam23 @KonstantinEpam
#6556 - Expanded macromolecules in Micro Mode causes unintended mergi…
1328fca 
…ng (#6567)

Co-authored-by: Konstantin Levin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Macro-Micro Bucket: Macro-Micro View related issues Priority: High Severity: High High level visibility to the user User`s Feedback
Projects
None yet
Milestone
Ketcher 3.0.2
2 participants
@Zhirnoff @KonstantinEpam23