Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover support to menu in desktop mode #326

Closed
valadas opened this issue Jun 3, 2021 · 2 comments · Fixed by #344
Closed

Add hover support to menu in desktop mode #326

valadas opened this issue Jun 3, 2021 · 2 comments · Fixed by #344
Labels
enhancement New feature or request
Milestone

Comments

@valadas
Copy link
Collaborator

valadas commented Jun 3, 2021

Add hover support to menu in desktop mode

@jeremy-farrance
Copy link

Recommended reading from a friend. :)
https://css-tricks.com/in-praise-of-the-unambiguous-click-menu/

@valadas
Copy link
Collaborator Author

valadas commented Jun 3, 2021

I agree with most of that, but to support a wide use case, I want the base template to support having the parent page be a real page and not only contain it's sub-pages as well as many clients expecting hover behavior. It will be implemented in a fashion that is complementary and does not hinder mobile and keyboard support. I logged it here as I just released v1.0.0 (which had a goal of being totally bootstrap independent making it officially optional). I need to work some more on details of that menu though like hover and aria-attributes and even better keyboard support.

@valadas valadas added this to the 1.1.0 milestone Jul 14, 2021
@valadas valadas added the enhancement New feature or request label Jul 14, 2021
valadas added a commit that referenced this issue Jul 15, 2021
Users can now either hover each menu or click on the chevron in order to expand each menu.

Closes Add hover support to menu in desktop mode #326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants