Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECDSA Key/Hash algorithm sample error #59

Open
cyberphone opened this issue May 12, 2018 · 2 comments
Open

ECDSA Key/Hash algorithm sample error #59

cyberphone opened this issue May 12, 2018 · 2 comments

Comments

@cyberphone
Copy link
Collaborator

It seems that I haven't read JWA down to the letter.
If I understand things right ES256 is dedicated to to ECSDSA with P-256 and SHA256 making this example of ours incorrect:
https://tools.ietf.org/id/draft-erdtman-jose-cleartext-jws-00.html#multipleglobalalg
I have created an alternative test key called P-256-2 and associated sample to cope with that.
@erdtman
Copy link
Owner

erdtman commented May 14, 2018

That explains why I could not verify that example with my implementation.
Could you create new Examples?

@cyberphone
Copy link
Collaborator Author

Sample: https://github.com/cyberphone/openkeystore/blob/jose-compatible/testdata/signatures-jose/p256%23es256%2Cp256-2%23es256%40mult-glob%2Balg-kid.json

Key: https://github.com/cyberphone/openkeystore/blob/jose-compatible/testdata/keys/p256-2privatekey.jwk

@erdtman erdtman mentioned this issue Sep 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed canonicalization format and fixed a set of minor issues erdtman/Cleartext-JOSE
2 participants
@erdtman @cyberphone