Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always-on expiration doesn't persist #2204

Closed
slingamn opened this issue Dec 25, 2024 · 2 comments
Closed

always-on expiration doesn't persist #2204

slingamn opened this issue Dec 25, 2024 · 2 comments

Comments

@slingamn
Copy link
Member

We expire always-on clients if they're idle too long:

ergo/irc/server.go

Lines 278 to 283 in 375079e

if checkExpiration && client.IsExpiredAlwaysOn(config) {
// TODO save the channels list, use it for autojoin if/when they return?
server.logger.Info("accounts", "Expiring always-on client", client.AccountName())
client.destroy(nil)
continue
}

but when the server restarts, we recreate them, which seems wrong.

@slingamn slingamn added the bug label Dec 25, 2024
@slingamn slingamn added this to the v2.15 milestone Dec 25, 2024
@slingamn
Copy link
Member Author

We already have the persistent data we need to implement this because we track lastSeen! We just need to check it before creating the always-on client.

@slingamn slingamn removed the bug label Dec 26, 2024
@slingamn slingamn removed this from the v2.15 milestone Dec 26, 2024
@slingamn
Copy link
Member Author

Somehow I missed that we already have this? 48166b5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant