Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUIT does not respect server-time #2218

Closed
slingamn opened this issue Feb 13, 2025 · 0 comments
Closed

QUIT does not respect server-time #2218

slingamn opened this issue Feb 13, 2025 · 0 comments
Labels
Milestone

Comments

@slingamn
Copy link
Member

e.g. :[email protected] QUIT :Ping timeout: 2m30s

ergo/irc/client.go

Lines 1193 to 1197 in 7e18362

// #364: don't send QUIT lines to unregistered clients
if client.registered {
quitMsg := ircmsg.MakeMessage(nil, client.nickMaskString, "QUIT", message)
finalData, _ = quitMsg.LineBytesStrict(false, MaxLineLen)
}

Right now we send the same QUIT line to all sessions regardless of their caps. This should respect the server-time cap.

@slingamn slingamn added the bug label Feb 13, 2025
@slingamn slingamn added this to the v2.16 milestone Feb 13, 2025
slingamn added a commit that referenced this issue Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant