Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies between API Documentation and Implementation #75

Open
ageofalgo opened this issue Jan 27, 2025 · 1 comment
Open

Inconsistencies between API Documentation and Implementation #75

ageofalgo opened this issue Jan 27, 2025 · 1 comment

Comments

@ageofalgo
Copy link

Hi! Great work, I am spending some time on this hoping to use it as a preferred option. Encountered some issues when trying to launch Agent studio. Maybe it's just me but I thought I'd leave it here.

Description

While implementing an AI agent using the Eternal AI framework, I encountered some inconsistencies between the documentation and the actual implementation.

1. API Documentation vs testing

// What documentation suggests:
import { BaseDagent, IAgentCharacter, InitAgent } from "@eternal-dagent/core";

// What actually works:
import { 
  AgentClient as BaseDagent,
  IAgentCharacter,
  IAgent as InitAgent 
} from "@eternal-dagent/core";

2. Method Availability

The createAgent() method is referenced but It can't be found on AgentClient:

// What documentation suggests:
const res: IAgent = (await baseAgent.createAgent()) as IAgent;

// What actually works:
const res: IAgent = await AgentClient.create(baseAgent) as IAgent;

3. Type System Issues

  • TypeScript version conflicts, TypeScript defined in both dependencies and devDependencies. (requires TS 4.9.5)
  • Missing type definitions for core components
  • Inconsistent naming between types and implementations

Steps to Reproduce

  1. Create new project using Agent Studio
  2. Install dependencies
  3. Try to create an agent following the documentation
  4. Encounter missing exports and methods

Environment

  • Node.js: [v 22.12.0]
  • TypeScript: 4.9.5
  • @eternal-dagent/core:
  • Operating System: [Mac OS X]

Current Workarounds

  1. Use correct imports:
import { 
  AgentClient as BaseDagent,
  IAgentCharacter,
  IAgent as InitAgent 
} from "@eternal-dagent/core";
  1. Use correct method calls:
const res: IAgent = await AgentClient.create(baseAgent) as IAgent;
  1. Pin TypeScript version to 4.9.5

Suggested Improvements

  1. Update documentation to reflect actual exports and methods
  2. Provide comprehensive type definitions
  3. Maintain consistency between docs and implementation
  4. Add version compatibility guide
  5. Consider adding migration documentation
@6789tc
Copy link
Collaborator

6789tc commented Feb 3, 2025

hey @ageofalgo, thanks for creating the issue, we are looking into it and will get back to you here soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants