Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Video Size - Draggable #58

Closed
packardone opened this issue May 26, 2020 · 3 comments · Fixed by #104
Closed

Custom Video Size - Draggable #58

packardone opened this issue May 26, 2020 · 3 comments · Fixed by #104

Comments

@packardone
Copy link
Contributor

Referencing the work that began in #52 (and the embedded comments in that thread):

There needs to be a way whether users can manually enlarge the video to whatever size they need. The problem is for users who are using sign language. That subset of users need to be able to make the video quite large, without impacting the "large" setting used by everyone else.

Perhaps an one solution to this would be to add a way to pop-out the video--so that individual video windows could be resized by resizing the pop-out browser window. Another option would be to allow the video corners to be draggable up to a specific maximum.

@orblivion
Copy link
Contributor

@JohnMcLear I had a heck of a time figuring out plain htm/javascript dragging on the various browsers I'm trying it on. Getting the x/y coordinates while dragging seems to not be supported.

It looks like there's dragging functionality built into jquery-ui. I'm wondering if it would be worth taking the time to try the same thing with that. It depends if you're inclined to add another dependency?

@JohnMcLear
Copy link
Member

JohnMcLear commented Jun 4, 2020

ugh really? That's horrible.. I thought canvas elements supported native resize: https://konvajs.org/docs/sandbox/Image_Resize.html - https://stackoverflow.com/questions/19100009/dragging-and-resizing-an-image-on-html5-canvas

Not as native as I thought though, that's crazy! I think you only need a draggable element on bottom right.

This one is prolly the nicest. https://interactjs.io/

@orblivion
Copy link
Contributor

I think you only need a draggable element on bottom right.

Yep. I'll give Interact a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants