Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Add CI check for running kurtosis / NAT tests against op-geth #504

Open
teddyknox opened this issue Feb 10, 2025 · 0 comments
Open

Comments

@teddyknox
Copy link

Rationale

Right now we are relying somewhat on monorepo tests such as the kurtosis, NAT and op-e2e tests for asserting the correctness of op-geth behaviors. It would be good to encode this reliance more explicitly by having the CI within op-geth run these tests in repo pull requests.

If we can write tests more simply by writing them using high-level test frameworks like those exposed by kurtosis and NAT, and also depend on these tests to be consulted before merging any code to the op-geth repo, then we can increase confidence in changes to the repo and increase test coverage by ensuring clean CI integration.

Implementation

Do you have ideas regarding the implementation of this feature?

TODO

Are you willing to implement this feature?

Yes, although it may be a better fit for the platform team.

@teddyknox teddyknox assigned teddyknox and unassigned teddyknox Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant