Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isthmus: tests of state transition with operator fees #528

Open
sebastianst opened this issue Feb 27, 2025 · 0 comments
Open

isthmus: tests of state transition with operator fees #528

sebastianst opened this issue Feb 27, 2025 · 0 comments

Comments

@sebastianst
Copy link
Member

sebastianst commented Feb 27, 2025

#388 implements the operator fee. It doesn't add tests of the STF with operator fees enabled. Test coverage of it only exists indirectly in the monorepo (see ethereum-optimism/optimism#12166).

If possible, it would be good to identify existing geth tests that we could parameterize to run with non-zero operator fee params so that there are also tests of the operator fee implementation in op-geth itself.

The test should also cover the case of non-zero state refunds. There were discrepancies in the Go and Rust implementations before, so we don't want a regression to slip unnoticed.

We also need to have a test that covers the Isthmus transition block, see this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant