Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snap colours] Wrong texture division on 2048 texture resolution option #935

Open
joleskins opened this issue Dec 16, 2020 · 1 comment
Open

Comments

@joleskins
Copy link
Contributor

joleskins commented Dec 16, 2020

Describe the bug
I've been trying to use a high resolution texture for notes with snap colours but the division from TapNoteNoteColorTextureCoordSpacingY=0.125 in metrics.ini seems to break if the game uses 2048 texture resolution, and the note textures aren't 64x64 (or 128x128 with a (doubleres) tag) per note. Using a custom res tag like (res 64x512) doesn't circumvent the issue. The texture I'm using is 192x1536. On lower texture resolution options, the division works fine

To Reproduce
Steps to reproduce the behavior:

  1. Set texture resolution in graphics options to 2048
  2. Use a texture that's not 64x512 or 128x1024 with a (doubleres) tag
  3. Texture now has wrong divisions for snaps
  4. Use a texture that is 64x512 or 128x1024 with a (doubleres) tag
  5. Texture is divided correctly

Expected behavior
Divide the same way as on lower texture resolution options

Screenshots

16th snaps with 192x1536 texture resolution and res tag (res 64x512)
(behaviour is the same with or without the res tag)
Hi-res

16th snaps with 128x1024 texture resolution and a (doubleres) tag
Std-res
Version:

  • 0.70.3

Additional context:
MultiplyByZero was used as a noteskin base for testing

@joleskins joleskins changed the title [Snap colours] Wrong texture division on non-standard sprite resolution [Snap colours] Wrong texture division on 2048 texture resolution option Nov 25, 2022
@joleskins
Copy link
Contributor Author

joleskins commented Nov 25, 2022

new info on this:
Texture division is only wrong here because of using the high res notes while 2048 texture res is selected. with lower settings, the division works but of course the texture gets downscaled on lower settings so it defeats the purpose of using higher res notes. still worth looking into fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants