From c70e1438f5641f8bde568e6b1b04791bfd3d1ba7 Mon Sep 17 00:00:00 2001 From: Like Date: Wed, 6 Nov 2019 14:06:41 +0800 Subject: [PATCH] Remove outdated method doc (#5422) --- .../pulsar/broker/service/AbstractBaseDispatcher.java | 2 -- .../pulsar/broker/service/PulsarChannelInitializer.java | 6 ++++-- .../pulsar/broker/stats/metrics/AbstractMetrics.java | 7 +++---- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractBaseDispatcher.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractBaseDispatcher.java index d582db8fe3fa4..bb9acb61c6973 100644 --- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractBaseDispatcher.java +++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractBaseDispatcher.java @@ -62,8 +62,6 @@ protected AbstractBaseDispatcher(Subscription subscription) { * * @param sendMessageInfo * an object where the total size in messages and bytes will be returned back to the caller - * @param subscription - * the subscription object */ public void filterEntriesForConsumer(List entries, EntryBatchSizes batchSizes, SendMessageInfo sendMessageInfo) { diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarChannelInitializer.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarChannelInitializer.java index fafec4d84c301..9fb81ec2b1631 100644 --- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarChannelInitializer.java +++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarChannelInitializer.java @@ -39,8 +39,10 @@ public class PulsarChannelInitializer extends ChannelInitializer private final ServiceConfiguration brokerConf; /** - * - * @param brokerService + * @param pulsar + * An instance of {@link PulsarService} + * @param enableTLS + * Enable tls or not */ public PulsarChannelInitializer(PulsarService pulsar, boolean enableTLS) throws Exception { super(); diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/metrics/AbstractMetrics.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/metrics/AbstractMetrics.java index 32e3214b82a22..85a32df8c53fd 100644 --- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/metrics/AbstractMetrics.java +++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/metrics/AbstractMetrics.java @@ -141,8 +141,7 @@ protected String parseNamespaceFromLedgerName(String ledgerName) { * Creates a dimension key for metrics * * @param namespace - * @param fromClusterName - * @param toClusterName + * Namespace of metric * @return */ protected Metrics createMetricsByDimension(String namespace) { @@ -223,8 +222,8 @@ protected void populateMaxMap(Map map, String mkey, long value) { * Helper to manage populating topics map * * @param ledgersByDimensionMap - * @param dimensionKey - * @param destStats + * @param metrics + * @param ledger */ protected void populateDimensionMap(Map> ledgersByDimensionMap, Metrics metrics, ManagedLedgerImpl ledger) {