Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request on VIsXYLabels: Making the label border radious configurable #424

Open
ManuelOchagavia opened this issue Aug 5, 2024 · 3 comments

Comments

@ManuelOchagavia
Copy link

I've seen in the code that the border radious rx and ry depends on the font size. I would like to request or have permission to add that feature to the component.

@lee00678
Copy link
Collaborator

lee00678 commented Aug 5, 2024

Hi @ManuelOchagavia, glad you want to contribute. We are an open source project, you don't need additional permissions to contribute. See our contributing guidelines here.

@ManuelOchagavia
Copy link
Author

Hello @lee00678

First of all, thanks for the answer! On the other hand, I've been trying to do so. But the guidelines are a bit vague on how actually the development process works. I've made changes locally on my machine, but the changes don't seem to work.... Could you help me or give me the steps that I should follow to see my changes on the unovis sandbox? (As sandbox I mean the gallery that you can run on the packages/website)

@lee00678
Copy link
Collaborator

lee00678 commented Sep 3, 2024

Hi @ManuelOchagavia, do you mean you don't see changes on http://localhost:9300/? If you do npm run website, it should open up a new page in your browser, and you changes should be reflected there. However, if you are modifying files under ts folder, npm run website doesn't automatically watch for those changes, you will need to do a build before you see the changes. A better way to test your update while developing would be run npm run dev, as mentioned here. This is a separate page we use for development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants