zendesk #34016, cannot modify contact header.

Author: Hoan HL

containers/sip-servlets-as7/src/main/java/org/mobicents/servlet/sip/startup/SipStandardContext.java

@@ -128,10 +128,6 @@ public class SipStandardContext extends StandardContext implements CatalinaSipCo
 	// application session is 3 minutes
 	private static int DEFAULT_LIFETIME = 3;
 
-	// default quotable params that their values need to be quoted.
-	private static final String DEFAULT_QUOTABLE_PARAMS = "vendor, model, version, cnonce, nextnonce,"
-			+ "nonce, code, oc-algo, cid, text, domain, opaque, qop, realm, response, rspauth, uri, username";
-	
 	// The key to get configurable timer serive pool size
     private static final String TIMER_SERVICE_POOL_SIZE = "org.restcomm.servlets.sip.TIMER_SERVICE_THREADS";
 
@@ -318,32 +314,8 @@ protected void initInternalApplicationComponents() throws LifecycleException {
                 proxyTimerService = new ProxyTimerServiceImpl(applicationName);
             }
         }
-        this.getServletContext().setAttribute("org.restcomm.servlets.sip.QUOTABLE_PARAMETER",
-                getQuotableParams());
-        this.getServletContext().setAttribute("org.restcomm.servlets.sip.REQUEST_TERMINATED_REASON",
-                this.getServletContext().getInitParameter("org.restcomm.servlets.sip.REQUEST_TERMINATED_REASON"));
     }
 
-	/**
-	 * 
-	 * @return a list of known params that their values need to be quoted.
-	 */
-	private List<String> getQuotableParams(){
-		List<String> retValue = new ArrayList<String>();
-		String quotableParameters = this.getServletContext().getInitParameter("org.restcomm.servlets.sip.QUOTABLE_PARAMETER");
-		if (quotableParameters == null){
-			quotableParameters = DEFAULT_QUOTABLE_PARAMS;
-		}
-		String[] parameters = quotableParameters.split(",");
-		for (int i = 0; i < parameters.length; i++){
-			String param = parameters[i].trim();
-			if (param != null && !param.isEmpty() && !retValue.contains(param)){
-				retValue.add(param);
-			}
-		}
-		return retValue;
-	}
-	
 	/**
 	 * @throws Exception
 	 */

containers/tomcat-7/src/main/java/org/mobicents/servlet/sip/startup/SipStandardContext.java

@@ -134,10 +134,6 @@ public class SipStandardContext extends StandardContext implements CatalinaSipCo
 	// application session is 3 minutes
 	private static int DEFAULT_LIFETIME = 3;
 
-	// default quotable params that their values need to be quoted.
-	private static final String DEFAULT_QUOTABLE_PARAMS = "vendor, model, version, cnonce, nextnonce,"
-			+ "nonce, code, oc-algo, cid, text, domain, opaque, qop, realm, response, rspauth, uri, username";
-	
 	// The key to get configurable timer serive pool size
 	private static final String TIMER_SERVICE_POOL_SIZE = "org.restcomm.servlets.sip.TIMER_SERVICE_THREADS";
 
@@ -307,32 +303,8 @@ protected void initInternalApplicationComponents() throws LifecycleException {
                 proxyTimerService = new ProxyTimerServiceImpl(applicationName);
             }
         }
-        this.getServletContext().setAttribute("org.restcomm.servlets.sip.QUOTABLE_PARAMETER",
-                getQuotableParams());
-        this.getServletContext().setAttribute("org.restcomm.servlets.sip.REQUEST_TERMINATED_REASON",
-                this.getServletContext().getInitParameter("org.restcomm.servlets.sip.REQUEST_TERMINATED_REASON"));
     }
 
-	/**
-	 * 
-	 * @return a list of known params that their values need to be quoted.
-	 */
-	private List<String> getQuotableParams(){
-		List<String> retValue = new ArrayList<String>();
-		String quotableParameters = this.getServletContext().getInitParameter("org.restcomm.servlets.sip.QUOTABLE_PARAMETER");
-		if (quotableParameters == null){
-			quotableParameters = DEFAULT_QUOTABLE_PARAMS;
-		}
-		String[] parameters = quotableParameters.split(",");
-		for (int i = 0; i < parameters.length; i++){
-			String param = parameters[i].trim();
-			if (param != null && !param.isEmpty() && !retValue.contains(param)){
-				retValue.add(param);
-			}
-		}
-		return retValue;
-	}
-
 	/**
 	 * @throws Exception
 	 */

containers/tomcat-8/src/main/java/org/mobicents/servlet/sip/startup/SipStandardContext.java

@@ -140,10 +140,6 @@ public class SipStandardContext extends StandardContext implements CatalinaSipCo
 	// application session is 3 minutes
 	private static int DEFAULT_LIFETIME = 3;
 
-    // default quotable params that their values need to be quoted.
-    private static final String DEFAULT_QUOTABLE_PARAMS = "vendor, model, version, cnonce, nextnonce,"
-        + "nonce, code, oc-algo, cid, text, domain, opaque, qop, realm, response, rspauth, uri, username";
-    
     // The key to get configurable timer serive pool size
     private static final String TIMER_SERVICE_POOL_SIZE = "org.restcomm.servlets.sip.TIMER_SERVICE_THREADS";
 
@@ -312,30 +308,6 @@ protected void initInternalApplicationComponents() throws LifecycleException {
                 proxyTimerService = new ProxyTimerServiceImpl(applicationName);
             }
         }
-        this.getServletContext().setAttribute("org.restcomm.servlets.sip.QUOTABLE_PARAMETER",
-                getQuotableParams());
-        this.getServletContext().setAttribute("org.restcomm.servlets.sip.REQUEST_TERMINATED_REASON",
-                this.getServletContext().getInitParameter("org.restcomm.servlets.sip.REQUEST_TERMINATED_REASON"));
-    }
-
-    /**
-     *
-     * @return a list of known params that their values need to be quoted.
-     */
-    private List<String> getQuotableParams(){
-        List<String> retValue = new ArrayList<String>();
-        String quotableParameters = this.getServletContext().getInitParameter("org.restcomm.servlets.sip.QUOTABLE_PARAMETER");
-        if (quotableParameters == null){
-            quotableParameters = DEFAULT_QUOTABLE_PARAMS;
-        }
-        String[] parameters = quotableParameters.split(",");
-        for (int i = 0; i < parameters.length; i++){
-            String param = parameters[i].trim();
-            if (param != null && !param.isEmpty() && !retValue.contains(param)){
-                retValue.add(param);
-            }
-        }
-        return retValue;
     }
 
 	/**