Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] {#} isn't checked within MATT's Run Macro arguments #28

Open
PlasticMohawk opened this issue Jun 23, 2023 · 0 comments
Open

[BUG] {#} isn't checked within MATT's Run Macro arguments #28

PlasticMohawk opened this issue Jun 23, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@PlasticMohawk
Copy link

PlasticMohawk commented Jun 23, 2023

Describe the bug

The primary issue is tags used in MATT's Run Macro command as arguments, which contain {#} (for use with Token Attacher prefabs), do not seem to be "checked" when an instance of the TA prefab is created.

Please feel free to reach out in Discord if you have any questions. Username: plasticmohawk

To Reproduce

Using MATT and Token Attacher, I have created a portal entrance and exit. You can see this in operation in the JB2A Discord (link).

The prefab of each side of the portal uses the following tags:

portal-enter-{#}
portal-exit-{#}

The MATT actions of the "entrance" and "exit" prefabs are set up like this:

image

When I create an instance of these prefabs (by dragging the TA prefab from the right sidebar), the tags unfurl as expected, like this:

image

However, the Teleport actions of the instances now look like this:

image

Further, the arguments of the Run Macro don't seem to unfurl at all. See below:

"Entrance" side of the portal
image

"Exit" side of the portal
image

As a result, I need to manually edit my tag values to ensure my Rube Goldberg machine of a portal system works correctly.

Expected behavior

As a user, I...

  • expect any tags within MATT's Run Macro arguments to replace {#} with an actual number.
  • expect tags with {#} within MATT's Teleport command to refer back to the correct tag serialization (though logically speaking I'm not sure if there's an elegant way to handle this)

Screenshots
See above

Setup:

  • Foundry Version: 10.291
  • System Version: PF2E 4.12.9
  • Tagger Version: 1.4.5
  • Browser & version: Chrome 114.0.5735.134

Active modules:

  • Tagger
  • MATT
  • Sequencer
  • Token Attacher

Additional context

Below is the JS of the macro being referenced above.

const [enter] = await Tagger.getByTag(args[0]);
const [exit] = await Tagger.getByTag(args[1]);

/*
ui.notifications.info("From: " + enter.id);
ui.notifications.info("To: " + exit.id);
*/

let sequence = new Sequence()
    .wait(200)
    .effect()
        .file("modules/jb2a_patreon/Library/1st_Level/Shield/Shield_02_Regular_Red_Intro_400x400.webm")
        .atLocation(enter)
        .scale(1)
    .wait(200)
    .effect()
        .file("modules/jb2a_patreon/Library/1st_Level/Shield/Shield_02_Regular_Red_OutroFade_400x400.webm")
        .atLocation(exit)
        .scale(1)
sequence.play();
@PlasticMohawk PlasticMohawk added the bug Something isn't working label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants