Skip to content

Commit 1732654

Browse files
committed
WinGui: Turn Full debug on for the Windows GUI, and include pdb's in the nightly builds.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@4531 b64f7644-9d1e-0410-96f1-a4d463321fa5
1 parent e3a97d6 commit 1732654

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed

win/CS/HandBrake.ApplicationServices/HandBrake.ApplicationServices.csproj

+5-1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
<OutputPath>bin\x86\Release\</OutputPath>
2929
<Optimize>true</Optimize>
3030
<DefineConstants>DEBUG;TRACE</DefineConstants>
31+
<DebugType>pdbonly</DebugType>
32+
<DebugSymbols>true</DebugSymbols>
3133
</PropertyGroup>
3234
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x64'">
3335
<PlatformTarget>x64</PlatformTarget>
@@ -37,8 +39,10 @@
3739
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|x64'">
3840
<PlatformTarget>x64</PlatformTarget>
3941
<OutputPath>bin\x64\Release\</OutputPath>
40-
<DefineConstants>TRACE</DefineConstants>
42+
<DefineConstants>DEBUG;TRACE</DefineConstants>
4143
<Optimize>true</Optimize>
44+
<DebugType>pdbonly</DebugType>
45+
<DebugSymbols>true</DebugSymbols>
4246
</PropertyGroup>
4347
<ItemGroup>
4448
<Reference Include="Caliburn.Micro">

win/CS/HandBrakeCS.csproj

+3-2
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,11 @@
4848
<PlatformTarget>x86</PlatformTarget>
4949
<OutputPath>bin\x86\Release\</OutputPath>
5050
<UseVSHostingProcess>false</UseVSHostingProcess>
51-
<DefineConstants>
52-
</DefineConstants>
51+
<DefineConstants>TRACE;DEBUG</DefineConstants>
5352
<Optimize>true</Optimize>
5453
<CodeAnalysisRuleSet>AllRules.ruleset</CodeAnalysisRuleSet>
54+
<DebugType>pdbonly</DebugType>
55+
<DebugSymbols>true</DebugSymbols>
5556
</PropertyGroup>
5657
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x64'">
5758
<PlatformTarget>x64</PlatformTarget>

win/CS/Installer/MakeNightly.nsi.tmpl

+1
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ Section "Handbrake" SEC01
132132
File "*.dll"
133133
File "*.config"
134134
File "*.xml"
135+
File "*.pdb"
135136

136137
; Copy the standard doc set into the doc folder
137138
SetOutPath "$INSTDIR\doc"

win/CS/Installer/MakeNightly64.nsi.tmpl

+1
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ Section "Handbrake" SEC01
131131
File "*.dll"
132132
File "*.config"
133133
File "*.xml"
134+
File "*.pdb"
134135

135136
; Copy the standard doc set into the doc folder
136137
SetOutPath "$INSTDIR\doc"

win/CS/Program.cs

-3
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,6 @@ public static void Main(string[] args)
5656
return;
5757
}
5858

59-
// Make sure the GUI knows what CLI version it's attached to.
60-
Functions.Main.SetCliVersionData();
61-
6259
// Check were not running on a screen that's going to cause some funnies to happen.
6360
Screen scr = Screen.PrimaryScreen;
6461
if ((scr.Bounds.Width < 1024) || (scr.Bounds.Height < 620))

0 commit comments

Comments
 (0)