Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should cross-package imports inside type definitions be relative or global? #2

Open
erkie opened this issue Sep 10, 2023 · 0 comments
Open

Should cross-package imports inside type definitions be relative or global? #2

erkie opened this issue Sep 10, 2023 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@erkie
Copy link
Member

erkie commented Sep 10, 2023

Right now I'm using relative paths (import { ModelSchema, Snapshot, SnapshotRecordArray } from "../model";) instead of referencing @ember-data. Not sure if this is correct and best practice, or if the @ember-data import namespace should be specified somewhere in the package?
@erkie erkie added the help wanted Extra attention is needed label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erkie