Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should v3, v2 directories still exist, and should previous types be moved to v4? #4

Open
erkie opened this issue Sep 10, 2023 · 0 comments
Open

Should v3, v2 directories still exist, and should previous types be moved to v4? #4

erkie opened this issue Sep 10, 2023 · 0 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@erkie
Copy link
Member

erkie commented Sep 10, 2023

In this commit: 3de489e I removed the v2- and v3-directories. It messed up global cmd+f and was just causing confusion when trying to navigate the project. My plan is to revert that commit when getting ready to make a PR to https://github.com/DefinitelyTyped/DefinitelyTyped but should I also move the old definitions to v4?
@erkie erkie added help wanted Extra attention is needed question Further information is requested labels Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erkie