Skip to content

Latest commit

 

History

History
188 lines (128 loc) · 9.44 KB

CONTRIBUTING.md

File metadata and controls

188 lines (128 loc) · 9.44 KB
Raw

Contributing

First of all, thank you for contributing to Meilisearch! The goal of this document is to provide everything you need to know in order to contribute to Meilisearch and its different integrations.

Hacktoberfest 2022

It's Hacktoberfest month! 🥳

Thanks so much for participating with Meilisearch this year!

  1. We will follow the quality standards set by the organizers of Hacktoberfest (see detail on their website). Our reviewers will not consider any PR that doesn’t match that standard.
  2. PRs reviews will take place from Monday to Thursday, during usual working hours, CEST time. If you submit outside of these hours, there’s no need to panic; we will get around to your contribution.
  3. There will be no issue assignment as we don’t want people to ask to be assigned specific issues and never return, discouraging the volunteer contributors from opening a PR to fix this issue. We take the liberty to choose the PR that best fixes the issue, so we encourage you to get to it as soon as possible and do your best!

You can check out the longer, more complete guideline documentation here.

Assumptions

  1. You're familiar with GitHub and the Pull Request (PR) workflow.
  2. You've read the Meilisearch documentation and the README.
  3. You know about the Meilisearch community. Please use this for help.

How to Contribute

  1. Make sure that the contribution you want to make is explained or detailed in a GitHub issue! Find an existing issue or open a new one.
  2. Once done, fork the meilisearch-js repository in your own GitHub account. Ask a maintainer if you want your issue to be checked before making a PR.
  3. Create a new Git branch.
  4. Review the Development Workflow section that describes the steps to maintain the repository.
  5. Make the changes on your branch.
  6. Submit the branch as a PR pointing to the main branch of the main meilisearch-js repository. A maintainer should comment and/or review your Pull Request within a few days. Although depending on the circumstances, it may take longer.
    We do not enforce a naming convention for the PRs, but please use something descriptive of your changes, having in mind that the title of your PR will be automatically added to the next release changelog.

Development Workflow

Requirements

To run this project, you will need:

  • Node.js >= v14 and node <= 18
  • Yarn

Setup

You can set up your local environment natively or using docker, check out the docker-compose.yml.

Example of running all the checks with docker:

docker-compose run --rm package bash -c "yarn install && yarn test && yarn lint"

To install dependencies:

yarn --dev

Tests and Linter

Each PR should pass the tests and the linter to be accepted.

# Tests
curl -L https://install.meilisearch.com | sh # download Meilisearch
./meilisearch --master-key=masterKey --no-analytics # run Meilisearch
yarn test
# Linter
yarn style
# Linter with fixing
yarn style:fix
# Build the project
yarn build

Git Guidelines

Git Branches

All changes must be made in a branch and submitted as PR. We do not enforce any branch naming style, but please use something descriptive of your changes.

Git Commits

As minimal requirements, your commit message should:

  • be capitalized
  • not finish by a dot or any other punctuation character (!,?)
  • start with a verb so that we can read your commit message this way: "This commit will ...", where "..." is the commit message. e.g.: "Fix the home page button" or "Add more tests for create_index method"

We don't follow any other convention, but if you want to use one, we recommend this one.

GitHub Pull Requests

Some notes on GitHub PRs:

  • Convert your PR as a draft if your changes are a work in progress: no one will review it until you pass your PR as ready for review.
    The draft PR can be very useful if you want to show that you are working on something and make your work visible.
  • The branch related to the PR must be up-to-date with main before merging. Fortunately, this project integrates a bot to automatically enforce this requirement without the PR author having to do it manually.
  • All PRs must be reviewed and approved by at least one maintainer.
  • The PR title should be accurate and descriptive of the changes. The title of the PR will be indeed automatically added to the next release changelogs.

Release Process (for internal team only)

Meilisearch tools follow the Semantic Versioning Convention.

Automation to Rebase and Merge the PRs

This project integrates a bot that helps us manage pull requests merging.
Read more about this.

Automated Changelogs

This project integrates a tool to create automated changelogs.
Read more about this.

How to Publish the Release

⚠️ Before doing anything, make sure you got through the guide about Releasing an Integration.

Make a PR modifying the following files with the right version:

package.json:

"version": "X.X.X",

src/package-version

export const PACKAGE_VERSION = 'X.X.X'

Once the changes are merged on main, you can publish the current draft release via the GitHub interface: on this page, click on Edit (related to the draft release) > update the description (be sure you apply these recommandations) > when you are ready, click on Publish release.

GitHub Actions will be triggered and push the package to npm.

Release a beta Version

Here are the steps to release a beta version of this package:

  • Create a new branch containing the "beta" changes with the following format xxx-beta where xxx explains the context.

    For example:

    • When implementing a beta feature, create a branch my-feature-beta where you implement the feature.

        git checkout -b my-feature-beta

    • During the Meilisearch pre-release, create a branch originating from bump-meilisearch-v*.*.* named meilisearch-v*.*.*-beta.
      v*.*.* is the next version of the package, NOT the version of Meilisearch!

      git checkout bump-meilisearch-v*.*.*
git pull origin bump-meilisearch-v*.*.*
git checkout -b bump-meilisearch-v*.*.*-beta

  • Change the version in package.json and in src/package-version with *.*.*-xxx-beta.0 and commit it to the beta branch.

  • Go to the GitHub interface for releasing: on this page, click on Draft a new release.

  • Create a GitHub pre-release:

    • Fill the description with the detailed changelogs
    • Fill the title with vX.X.X-beta.0
    • Fill the tag with vX.X.X-beta.0
    • ⚠️ Select the vX.X.X-beta.0 branch and NOT main
    • ⚠️ Click on the "This is a pre-release" checkbox
    • Click on "Publish release"

GitHub Actions will be triggered and push the beta version to npm.

💡 If you need to release a new beta for the same version (i.e. vX.X.X-beta.1):

Thank you again for reading this through, we can not wait to begin to work with you if you made your way through this contributing guide ❤️