Whitelists: use non-dynamic objects directly instead of mocking them. (…

…jendrikseipp#137)

NEWS.rst

@@ -6,6 +6,7 @@ News
 * Don't import any Vulture modules in setup.py (thanks @RJ722).
 * Add ``*-test.py`` to recognized test file patterns.
 * Add ``failureException``, ``longMessage`` and ``maxDiff`` to ``unittest`` whitelist.
+* Refer to actual objects rather than their mocks in default whitelists.
 
 
 0.27 (2018-06-05)

TODO.rst

@@ -4,7 +4,6 @@ TODOs
 * Use coverage.py to detect false-positives (#109).
 * Write script for turning SIP files into whitelists (#8).
 * Add PyQT whitelist to Vulture repo?
-* Use real objects instead of mocks in whitelists where possible (#136).
 
 
 Non-TODOs

vulture/core.py

@@ -218,7 +218,7 @@ def exclude_file(name):
 
         unique_imports = set(item.name for item in self.defined_imports)
         for import_name in unique_imports:
-            path = os.path.join('whitelists', import_name) + '.py'
+            path = os.path.join('whitelists', import_name) + '_whitelist.py'
             if exclude_file(path):
                 self._log('Excluded whitelist:', path)
             else:

vulture/whitelists/argparse_whitelist.py

@@ -0,0 +1,7 @@
+import argparse
+
+_ = argparse.ArgumentParser()
+_.epilog
+
+argparse.ArgumentDefaultsHelpFormatter._fill_text
+argparse.ArgumentDefaultsHelpFormatter._get_help_string

vulture/whitelists/collections_whitelist.py

@@ -0,0 +1,4 @@
+import collections
+
+# To free memory, the "default_factory" attribute can be set to None.
+collections.defaultdict.default_factory

vulture/whitelists/sys_whitelist.py

@@ -0,0 +1,6 @@
+import sys
+
+# Never report redirected streams as unused.
+sys.stderr
+sys.stdin
+sys.stdout

vulture/whitelists/unittest_whitelist.py

@@ -0,0 +1,26 @@
+from unittest import TestCase
+
+TestCase.setUp
+TestCase.tearDown
+TestCase.setUpClass
+TestCase.tearDownClass
+TestCase.run
+TestCase.skipTest
+TestCase.debug
+TestCase.failureException
+TestCase.longMessage
+TestCase.maxDiff
+try:
+    # new in Python 3.4
+    TestCase.subTest
+except AttributeError:
+    pass
+
+try:
+    # unittest.mock was introduced in Python 3.3
+    from unittest import mock
+except ImportError:
+    pass
+else:
+    mock.Mock.return_value
+    mock.Mock.side_effect