Skip to content

Commit 5c8ee6d

Browse files
author
Eric Schoffstall
committed
Merge pull request gulpjs#924 from asfktz/patch-1
suggesting a cleaner way
2 parents 5c6ee7a + 54d7612 commit 5c8ee6d

File tree

1 file changed

+12
-19
lines changed

1 file changed

+12
-19
lines changed

docs/recipes/browserify-uglify-sourcemap.md

+12-19
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ Browserify with transforms and full sourcemaps that resolve to the original indi
99

1010
var browserify = require('browserify');
1111
var gulp = require('gulp');
12-
var source = require('vinyl-source-stream');
13-
var buffer = require('vinyl-buffer');
12+
var transform = require('vinyl-transform');
1413
var uglify = require('gulp-uglify');
1514
var sourcemaps = require('gulp-sourcemaps');
1615

@@ -20,25 +19,19 @@ var getBundleName = function () {
2019
return version + '.' + name + '.' + 'min';
2120
};
2221

23-
gulp.task('javascript', function() {
24-
25-
var bundler = browserify({
26-
entries: ['./app.js'],
27-
debug: true
22+
gulp.task('javascript', function () {
23+
// transform regular node stream to gulp (buffered vinyl) stream
24+
var browserified = transform(function(filename) {
25+
var b = browserify(filename);
26+
return b.bundle();
2827
});
29-
30-
var bundle = function() {
31-
return bundler
32-
.bundle()
33-
.pipe(source(getBundleName() + '.js'))
34-
.pipe(buffer())
35-
.pipe(sourcemaps.init({loadMaps: true}))
28+
29+
return gulp.src('./app.js')
30+
.pipe(browserified)
31+
.pipe(sourcemaps.init({loadMaps: true}))
3632
// Add transformation tasks to the pipeline here.
3733
.pipe(uglify())
38-
.pipe(sourcemaps.write('./'))
39-
.pipe(gulp.dest('./dist/js/'));
40-
};
41-
42-
return bundle();
34+
.pipe(sourcemaps.write('./'))
35+
.pipe(gulp.dest('./dist/js/'));
4336
});
4437
```

0 commit comments

Comments
 (0)