Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

[Known Issue] Deepspeed multiple loss support #4

Open
ncilfone opened this issue Jun 23, 2021 · 2 comments
Open

[Known Issue] Deepspeed multiple loss support #4

ncilfone opened this issue Jun 23, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ncilfone
Copy link
Contributor

If running with multiple losses Deepseep will currently fail as retain_graph is not passed to the backward call within the Deepspeed engine thus preventing multiple backward calls within stoke.

Please use a single loss function for the time being until this can be patched -- in most simple situations with multiple losses simply add them...

PR is currently opened to fix this: microsoft/DeepSpeed#1149

@ncilfone ncilfone added the bug Something isn't working label Jun 23, 2021
@ncilfone ncilfone self-assigned this Jun 23, 2021
@sualehasif
Copy link

We have been working with deepspeed and really need the retain_graph support. (We can't simply add our losses.) Waiting for this to be fixed :)

@ncilfone
Copy link
Contributor Author

@sualehasif

Heads up, I think you might have wanted to respond to the PR on the deepspeed repo instead of this one!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants