Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raising wait time in example from 10 to 30 gives better results? #11

Closed
rduivenvoorde opened this issue Jan 21, 2019 · 2 comments
Closed

Comments

@rduivenvoorde
Copy link

Hi, thanks for all the work! This works with me here in NL.
Trying out the plain examples, my feeling is that in this example:
examples/get-leaf-info.py
if you raise the wait time from 10 to 30 seconds that you will have a result within 1 minute.
While waiting 10 seconds it can run 'forever'.
Can others maybe reproduce this?

@filcole
Copy link
Owner

filcole commented Jan 21, 2019

Hi, I've just tried increasing the timeout from 10 to 30 to 60 and then 240 and don't get any different result back. I'm always getting

DEBUG:urllib3.connectionpool:https://gdcportalgw.its-mo.com:443 "POST /api_v181217_NE/gdc/BatteryStatusCheckResultRequest.php HTTP/1.1" 200 None
DEBUG:pycarwings2.pycarwings2:Response HTTP Status Code: 200
DEBUG:pycarwings2.pycarwings2:Response HTTP Response Body: b'{"status":200,"responseFlag":"0"}'
No update, see latest_battery_status has changed

I do think the initial timeout of 10 seconds is too quick, and will increase to 30 seconds.

@filcole
Copy link
Owner

filcole commented Jan 22, 2019

Increased timeout to 30 seconds in commit 5ab6c4a

@filcole filcole closed this as completed Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants