-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firebaseui doesn't work with sessionStorage when localStorage unavailable #1077
Comments
Hi @skouny, this is interesting. FirebaseUI checks for both sessionStorage and localStorage: firebaseui-web/javascript/utils/storage.js Lines 84 to 87 in 5ff6fde
However, it only seems to use sessionStorage and cookies, without any localStorage at all: firebaseui-web/javascript/utils/storage.js Lines 94 to 119 in 5ff6fde
Taking away the localStorage check seems like the right move to me. The codebase will need another look to confirm that localStorage really isn't used, though. I'll mark this as a bug. |
Can I work on this issue.. |
When localStorage unavailable doesn't work with sessionStorage
setPersistence was set to browserSessionPersistence before FirebaseUI init
The text was updated successfully, but these errors were encountered: