-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login > Bundle ID switcher (UPDATED in comments) #427
Comments
UPDATE: |
UPDATE 2:
|
UPDATE 3: @Clinton Illa, we have to do the same thing as we did for Android/iOS client ids for Strava and Fitbit providers authentication. For example, StravaControler sends oauth_url which contains |
hey @Clish254 to confirm, we have the following...
...which has new logic built in to switch keys based on The below is old and needs to stay for Fitlink...
...and the below is new and needs similar logic as above to switch... Strava
Fitbit
|
ref: #427 Signed-off-by: Jordan Hall <[email protected]>
ref: #427 Signed-off-by: Jordan Hall <[email protected]>
* fix: Use header to get the client id ref: #427
* ✨ 548 - auth logic base (Enter + Create + cooldown + on active) * fix: Use header to get the client id (#547) * fix: Use header to get the client id ref: #427 * ✨ 548 - final auth version * ✨ 548 - add setting toggle, request biometry on active * ✨ 548 - podfile * removed dollar item * fixes * fix: repair strava (#593) * fix: repair strava Signed-off-by: Jordan Hall <[email protected]> * fix: repair unit test Signed-off-by: Jordan Hall <[email protected]> --------- Signed-off-by: Jordan Hall <[email protected]> --------- Signed-off-by: Jordan Hall <[email protected]> Co-authored-by: KirillRodichev <[email protected]> Co-authored-by: Kirill Rodichev <[email protected]>
What we need is to add an optional param to
auth/connect
smt likeclientName = 'Fitlink' | 'BFIT'
. By default it should be ‘Fitlink’, so that we don’t have to change Fitlink app logic.Then we need to map this clientName to env variable. Now we use only
IOS_BUNDLE_ID
insideverifyProviderApple
but we need different bundle ids for each app. So you’ll have to replaceIOS_BUNDLE_ID
withFITLINK_IOS_BUNDLE_ID="com.fathomux.Fit-Link"
andBFIT_IOS_BUNDLE_ID="com.bfitcoin"
and use them herelet clientId = this.configService.get('IOS_BUNDLE_ID')
Originally posted by @paulgosnell in #396 (comment)
The text was updated successfully, but these errors were encountered: