fix: Use header to get the client id #547

Jordan-Hall · 2023-03-08T10:12:54Z

vercel · 2023-03-08T10:12:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
fitlink-monorepo	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 16, 2023 at 2:52PM (UTC)

apps/api/src/modules/providers/providers/fitbit/fitbit.service.ts

apps/mobile/android/app/version.properties

apps/mobile/src/api/index.ts

Jordan-Hall · 2023-03-08T10:50:12Z

@paulgosnell we will need to add the Environment vars for the build to work correctly in the secrets

FITLINK Strava

  FITLINK_STRAVA_CLIENT_ID: ${{ secrets.DEV_FITLINK_STRAVA_CLIENT_ID }}
  FITLINK_STRAVA_CLIENT_SECRET: ${{ secrets.DEV_FITLINK_STRAVA_CLIENT_SECRET }}

  # FITLINK Fitbit
  FITLINK_FITBIT_CLIENT_ID: ${{ secrets.DEV_FITLINK_FITBIT_CLIENT_ID }}
  FITLINK_FITBIT_CLIENT_SECRET: ${{ secrets.DEV_FITLINK_FITBIT_CLIENT_SECRET }}
  FITLINK_FITBIT_VERIFY_WEBHOOK_DEFAULT: ${{ secrets.DEV_FITLINK_FITBIT_VERIFY_WEBHOOK_DEFAULT }}
  FITLINK_FITBIT_VERIFY_WEBHOOK_ACTIVITIES: ${{ secrets.DEV_FITLINK_FITBIT_VERIFY_WEBHOOK_ACTIVITIES }}
  FITLINK_FITBIT_VERIFY_WEBHOOK_SLEEP: ${{ secrets.DEV_FITLINK_FITBIT_VERIFY_WEBHOOK_SLEEP }}

  # BFIT Strava
  BFIT_STRAVA_CLIENT_ID: ${{ secrets.DEV_BFIT_STRAVA_CLIENT_ID }}
  BFIT_STRAVA_CLIENT_SECRET: ${{ secrets.DEV_BFIT_STRAVA_CLIENT_SECRET }}

  # BFIT Fitbit
  BFIT_FITBIT_CLIENT_ID: ${{ secrets.DEV_BFIT_FITBIT_CLIENT_ID }}
  BFIT_FITBIT_CLIENT_SECRET: ${{ secrets.DEV_BFIT_FITBIT_CLIENT_SECRET }}
  BFIT_FITBIT_VERIFY_WEBHOOK_DEFAULT: ${{ secrets.DEV_BFIT_FITBIT_VERIFY_WEBHOOK_DEFAULT }}
  BFIT_FITBIT_VERIFY_WEBHOOK_ACTIVITIES: ${{ secrets.DEV_BFIT_FITBIT_VERIFY_WEBHOOK_ACTIVITIES }}
  BFIT_FITBIT_VERIFY_WEBHOOK_SLEEP: ${{ secrets.DEV_BFIT_FITBIT_VERIFY_WEBHOOK_SLEEP }}

paulgosnell · 2023-03-09T21:57:08Z

FITLINK_FITBIT_CLIENT_ID

This is done @Jordan-Hall - all added to both AWS EB env vars on prod and Github secrets

ref: #427 Signed-off-by: Jordan Hall <[email protected]>

added a default to the X-Client-ID for if its not set it goes to FitLink this is due to not updating fitlink Signed-off-by: Jordan Hall <[email protected]>

Signed-off-by: Jordan Hall <[email protected]>

apps/mobile/src/api/index.ts

* fix: Use header to get the client id ref: #427

* ✨ 548 - auth logic base (Enter + Create + cooldown + on active) * fix: Use header to get the client id (#547) * fix: Use header to get the client id ref: #427 * ✨ 548 - final auth version * ✨ 548 - add setting toggle, request biometry on active * ✨ 548 - podfile * removed dollar item * fixes * fix: repair strava (#593) * fix: repair strava Signed-off-by: Jordan Hall <[email protected]> * fix: repair unit test Signed-off-by: Jordan Hall <[email protected]> --------- Signed-off-by: Jordan Hall <[email protected]> --------- Signed-off-by: Jordan Hall <[email protected]> Co-authored-by: KirillRodichev <[email protected]> Co-authored-by: Kirill Rodichev <[email protected]>

vercel bot deployed to Preview March 8, 2023 10:21 View deployment

vercel bot deployed to Preview March 8, 2023 10:29 View deployment

Jordan-Hall force-pushed the feat/427-bunld-ip-driven branch from ff8f452 to 1798a55 Compare March 8, 2023 10:35

KirillRodichev reviewed Mar 8, 2023

View reviewed changes

apps/api/src/modules/providers/providers/fitbit/fitbit.service.ts Outdated Show resolved Hide resolved

apps/mobile/android/app/version.properties Outdated Show resolved Hide resolved

apps/mobile/src/api/index.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview March 8, 2023 10:39 View deployment

vercel bot deployed to Preview March 8, 2023 10:52 View deployment

vercel bot deployed to Preview March 8, 2023 11:05 View deployment

vercel bot deployed to Preview March 8, 2023 12:19 View deployment

vercel bot deployed to Preview March 8, 2023 12:27 View deployment

vercel bot deployed to Preview March 8, 2023 12:30 View deployment

Jordan-Hall force-pushed the feat/427-bunld-ip-driven branch from 2e0d4b2 to d85b623 Compare March 8, 2023 12:35

vercel bot deployed to Preview March 8, 2023 12:37 View deployment

vercel bot deployed to Preview March 8, 2023 13:25 View deployment

Jordan-Hall force-pushed the feat/427-bunld-ip-driven branch from 1df30fe to 1ee9cf2 Compare March 8, 2023 16:13

vercel bot deployed to Preview March 8, 2023 16:21 View deployment

vercel bot deployed to Preview March 8, 2023 16:29 View deployment

vercel bot deployed to Preview March 8, 2023 16:37 View deployment

Jordan-Hall added 9 commits March 12, 2023 22:19

fix: Use header to get the client id

4b27b2c

ref: #427 Signed-off-by: Jordan Hall <[email protected]>

fix(api): handle backward compatibility

ce8bfc5

added a default to the X-Client-ID for if its not set it goes to FitLink this is due to not updating fitlink Signed-off-by: Jordan Hall <[email protected]>

fix: rename the env to prefix with FITLINK_

d0e2f7c

Signed-off-by: Jordan Hall <[email protected]>

fix: duplicated import

30a454b

Signed-off-by: Jordan Hall <[email protected]>

fix: reapir health unit test

cf73c2c

Signed-off-by: Jordan Hall <[email protected]>

Fix: remove the forRoot and forFeature

9137ea4

Signed-off-by: Jordan Hall <[email protected]>

dont use mocktype. .get and request is transit

ed2db27

Signed-off-by: Jordan Hall <[email protected]>

fix: repair types

5cdd4c8

Signed-off-by: Jordan Hall <[email protected]>

fit: repair unit test

424e333

Signed-off-by: Jordan Hall <[email protected]>

Jordan-Hall force-pushed the feat/427-bunld-ip-driven branch from 0a43a94 to 424e333 Compare March 12, 2023 22:23

fix: changed the way it works

702b0a5

Signed-off-by: Jordan Hall <[email protected]>

vercel bot deployed to Preview March 13, 2023 22:48 View deployment

fix: match the new .env

142888c

Signed-off-by: Jordan Hall <[email protected]>

vercel bot deployed to Preview March 13, 2023 23:00 View deployment

Fix a couple more tests

943fc6f

Signed-off-by: Jordan Hall <[email protected]>

vercel bot deployed to Preview March 13, 2023 23:11 View deployment

auth require the param decorator

302cae2

Signed-off-by: Jordan Hall <[email protected]>

vercel bot deployed to Preview March 13, 2023 23:23 View deployment

fix: remove the over write of request

affddf6

Signed-off-by: Jordan Hall <[email protected]>

vercel bot deployed to Preview March 16, 2023 09:51 View deployment

Merge branch 'develop' into feat/427-bunld-ip-driven

a332e11

vercel bot deployed to Preview March 16, 2023 10:04 View deployment

feat: bad code just to fix unit tests

a46ae7f

Signed-off-by: Jordan Hall <[email protected]>

vercel bot deployed to Preview March 16, 2023 10:48 View deployment

fix: repair JWT issue in tests

e7454a7

Signed-off-by: Jordan Hall <[email protected]>

vercel bot deployed to Preview March 16, 2023 12:07 View deployment

fix: repair the param for ClientIdParam

2076440

Signed-off-by: Jordan Hall <[email protected]>

vercel bot deployed to Preview March 16, 2023 13:17 View deployment

fix: param needs to grab from the header not the request

3e1c8ba

Signed-off-by: Jordan Hall <[email protected]>

vercel bot deployed to Preview March 16, 2023 13:34 View deployment

fix: mock event emitter

9df1158

Signed-off-by: Jordan Hall <[email protected]>

vercel bot deployed to Preview March 16, 2023 14:38 View deployment

fix: repair the unit test

e647640

Signed-off-by: Jordan Hall <[email protected]>

vercel bot deployed to Preview March 16, 2023 14:52 View deployment

Jordan-Hall marked this pull request as ready for review March 16, 2023 15:01

Jordan-Hall commented Mar 16, 2023

View reviewed changes

apps/mobile/src/api/index.ts Show resolved Hide resolved

Jordan-Hall merged commit 7e0f1e4 into develop Mar 16, 2023

Jordan-Hall deleted the feat/427-bunld-ip-driven branch March 16, 2023 15:13

Jordan-Hall added a commit that referenced this pull request Mar 16, 2023

fix: Use header to get the client id (#547) (#582)

d2d5f61

* fix: Use header to get the client id ref: #427

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Use header to get the client id #547

fix: Use header to get the client id #547

Jordan-Hall commented Mar 8, 2023 •

edited

Loading

vercel bot commented Mar 8, 2023 •

edited

Loading

Jordan-Hall commented Mar 8, 2023

paulgosnell commented Mar 9, 2023

fix: Use header to get the client id #547

fix: Use header to get the client id #547

Conversation

Jordan-Hall commented Mar 8, 2023 • edited Loading

vercel bot commented Mar 8, 2023 • edited Loading

Jordan-Hall commented Mar 8, 2023

FITLINK Strava

paulgosnell commented Mar 9, 2023

Jordan-Hall commented Mar 8, 2023 •

edited

Loading

vercel bot commented Mar 8, 2023 •

edited

Loading