Missing format string in attack_take_screenshot.py

[1ncludeSteven]

Describe the bug
When running fkie-cad/socbed/src/attacks/attack_take_screenshot.py, a bug will occur because of missing format string in following lines:

def _collect_files(self):
        file = self.screenshot_file
        # !!!!!! we should use f"screenshot -p {file}" rather than "screenshot -p {file}"
        self.ssh_client.write_lines(self.handler.stdin, ["screenshot -p {file}",
                                                         "background"])

To Reproduce
use attackconsole, run c2_take_screenshot after running infect_email_exe

Expected behavior

Current behavior
A screenshot should be store in /root/screenshot.jpeg rather then saved in /root/{file}

[Maspital]

Thanks for the heads up :) my first thought was "why wasn't that caught by some unit tests" - turned out there are none for this specific attack.

Edit: Will be merged into main after pipeline https://github.com/fkie-cad/socbed/actions/runs/11029166801 completes