Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

Does this check in capella-1.11.5 branch break bundle cancellations? #52

Open
bkellerman opened this issue Mar 22, 2023 · 1 comment
Open

Comments

@bkellerman
Copy link
Contributor

A block with cancelled bundles could have less profit.

if payload.full == nil || fees.Cmp(payload.fullFees) > 0 {

@bkellerman bkellerman changed the title Does this check break bundle cancellations? Does this check in capella-1.11.5 branch break bundle cancellations? Mar 22, 2023
@Ruteri
Copy link
Collaborator

Ruteri commented Mar 22, 2023

I think it's alright
The check here makes it so that only the most valuable payload makes it into the relay submission code. But all of those payloads have the cancelled bundles in consideration, and even if the resulting payload has a smaller profit than the previous relay submission it should be still sent.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants