-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unstable behavior for sorting ascii file when openmp is enabled #22
Comments
Note that we can use only one core in the automatic testing server. It might be worth also testing on the local machine. |
i don't seem to get this error regardless of number of threads used. can you help to pinpoint where the error is occurring? |
@mfgu Closing. |
there may indeed a problem with openmp, as it is now failing the checks.
but it's not related to the PR#21. may resulted from an earlier PR. but I
have not been able to reproduce it in my local env.
…On Mon, Apr 9, 2018 at 10:31 PM, Keisuke Fujii ***@***.***> wrote:
@mfgu <https://github.com/mfgu>
But I became unable to reproduce this issue either in my environment and
in the automatic testing server.
Something wrong happened at that moment...
I appreciate you for checking this issue in your environment.
Closing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMnr8eOIY5RhgsN_ENwK9LEgE-IWIum5ks5tnBl0gaJpZM4TLZRh>
.
|
I restarted the testing system and the issue was not reproduced. I do not have time to investigate this today, but it could depend on the server condition, such as there are too many jobs...? |
issue fixed in PR#27 |
I think by #21 , the ascii file is now sorted even when openmp is enabled.
But the new behavior looks somehow unstable.
The tests passed when the PR is sent, but failed after the merge commit.
In my local environment,
sometimes fails and causes a segfault (but sometimes succeeds).
I guess it is failing when writing to the file?
The text was updated successfully, but these errors were encountered: