Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable behavior for sorting ascii file when openmp is enabled #22

Closed
fujiisoup opened this issue Apr 8, 2018 · 6 comments
Closed

Comments

@fujiisoup
Copy link
Collaborator

I think by #21 , the ascii file is now sorted even when openmp is enabled.

But the new behavior looks somehow unstable.
The tests passed when the PR is sent, but failed after the merge commit.

In my local environment,

cd demo/NeL
make openmp

sometimes fails and causes a segfault (but sometimes succeeds).
I guess it is failing when writing to the file?

@fujiisoup
Copy link
Collaborator Author

Note that we can use only one core in the automatic testing server. It might be worth also testing on the local machine.

@mfgu
Copy link
Collaborator

mfgu commented Apr 8, 2018

i don't seem to get this error regardless of number of threads used. can you help to pinpoint where the error is occurring?

@fujiisoup
Copy link
Collaborator Author

@mfgu
But I became unable to reproduce this issue either in my environment and in the automatic testing server.
Something wrong happened at that moment...
I appreciate you for checking this issue in your environment.

Closing.

@mfgu
Copy link
Collaborator

mfgu commented Apr 10, 2018 via email

@fujiisoup
Copy link
Collaborator Author

I restarted the testing system and the issue was not reproduced.

I do not have time to investigate this today, but it could depend on the server condition, such as there are too many jobs...?
I reopened this issue.

@fujiisoup fujiisoup reopened this Apr 11, 2018
@mfgu
Copy link
Collaborator

mfgu commented Apr 11, 2018

issue fixed in PR#27

@mfgu mfgu closed this as completed Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants