Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNV overrides are broken #1785

Closed
pauliusguzas opened this issue Nov 15, 2024 · 0 comments
Closed

RNV overrides are broken #1785

pauliusguzas opened this issue Nov 15, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pauliusguzas
Copy link
Collaborator

pauliusguzas commented Nov 15, 2024

Describe the bug
This override is set on renative.json

{
    "overrides": {
        "android/build.gradle": {
            "compile ": "implementation ",
            "com.github.prscX:photo-editor-android:master-SNAPSHOT": "com.github.prscX:photo-editor-android:master",
            "compileSdkVersion 28": "compileSdkVersion 33"
        }
    }
}

in .rnv/overrides/applied_overrides this is seen

"react-native-photo-editor": {
    "android/build.gradle": {
      "compile ": "implementation ",
      "com.github.prscX:photo-editor-android:master-SNAPSHOT": "com.github.prscX:photo-editor-android:master",
      "compileSdkVersion 28": "compileSdkVersion 33"
    },

but in .rnv/overrides/react-native-photo-editor/android/build.gradle there’s this (screenshot), and same in node_modules, so clearly override is not applied and this is causing broken builds after updating rnv to latest
image

Desktop (please complete the following information):

  • OS: Ventura 13.5.2
  • Node Version 18.18.0
  • RNV Version 1.6.0-rc.0
  • template-starter Version 1.6.0-rc.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants