Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change access control mechanism for protected channels #773

Open
JustinFarris opened this issue Apr 7, 2017 · 0 comments
Open

Change access control mechanism for protected channels #773

JustinFarris opened this issue Apr 7, 2017 · 0 comments

Comments

@JustinFarris
Copy link

Currently, the rule allowing the deletion of protected channels is just based on the host part of the request being "localhost". This is technically exploitable by a remote request if the host header is explicitly set.

If the intention is to truly require the client to be local to a hub node, there are numerous ways to test for that. One would be to require that the "REMOTE_ADDR" header be "127.0.0.1". There might be better options for this, too, or some other easy to use http ACL library out there that would allow a simple rule like this now, and more complex ones later if we ever need to actually manage remote access to editing protected channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant