Skip to content
This repository has been archived by the owner on Oct 30, 2020. It is now read-only.

Tests should not require any envars/external services when using mocks #222

Open
jonnor opened this issue Oct 20, 2017 · 0 comments
Open

Comments

@jonnor
Copy link
Member

jonnor commented Oct 20, 2017

Right now have to set HEROKU_API_KEY and GUV_BROKER. This is annoying to do when developing, and the envvars are not set on forked repos, which makes PRs fail by default.

Tests that need to run without mocks (real integration/end2end test) should be skipped, with a warning message.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant