You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
be sure to include the help target as a minimum in each Makefile, you do not need to add all targets that are sensible for all env
Review the VPC modules used, probably need to add a network target that uses terraform plan with -target and -out to generate a plan file to then apply.
Add a README.md if it is missing. Check main.tf in each example env, look for a block comment at the top of the file, and if present include those comments in the README.
Review each env as you work through them, if you have additional updates you would propose, let's discuss them and decide if they should go in this ticket or have a new ticket of their own.
The text was updated successfully, but these errors were encountered:
In this repo we have a collection of "example" (or "test") environments, seen here https://github.com/fpco/terraform-aws-foundation/blob/master/examples/. There are some inconsistencies with documentation and how to use the examples:
README
Makefile
-target
when first deploying the networkI would recommend the follow updates:
Makefile
if it is missing (see https://github.com/fpco/terraform-aws-foundation/blob/master/examples/cloud-dev-workspace/Makefile as a template to start with)help
target as a minimum in eachMakefile
, you do not need to add all targets that are sensible for all envnetwork
target that usesterraform plan
with-target
and-out
to generate a plan file to thenapply
.README.md
if it is missing. Checkmain.tf
in each example env, look for a block comment at the top of the file, and if present include those comments in theREADME
.Review each env as you work through them, if you have additional updates you would propose, let's discuss them and decide if they should go in this ticket or have a new ticket of their own.
The text was updated successfully, but these errors were encountered: