Skip to content

Commit 43ea4d0

Browse files
irengesravnborg
authored andcommitted
video: Add missing annotation for cyber2000fb_enable_ddc() and cyber2000fb_disable_ddc()
Sparse reports warnings at cyber2000fb_enable_ddc() and cyber2000fb_disable_ddc() warning: context imbalance in cyber2000fb_enable_ddc() - wrong count at exit warning: context imbalance in cyber2000fb_disable_ddc() - unexpected unlock The root cause is the missing annotation at cyber2000fb_enable_ddc() and cyber2000fb_disable_ddc() Add the missing __acquires(&cfb->reg_b0_lock) annotation Add the missing __releases(&cfb->reg_b0_lock) annotation Signed-off-by: Jules Irenge <[email protected]> Signed-off-by: Sam Ravnborg <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 71c4500 commit 43ea4d0

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/video/fbdev/cyber2000fb.c

+2
Original file line numberDiff line numberDiff line change
@@ -1160,12 +1160,14 @@ EXPORT_SYMBOL(cyber2000fb_detach);
11601160
#define DDC_SDA_IN (1 << 6)
11611161

11621162
static void cyber2000fb_enable_ddc(struct cfb_info *cfb)
1163+
__acquires(&cfb->reg_b0_lock)
11631164
{
11641165
spin_lock(&cfb->reg_b0_lock);
11651166
cyber2000fb_writew(0x1bf, 0x3ce, cfb);
11661167
}
11671168

11681169
static void cyber2000fb_disable_ddc(struct cfb_info *cfb)
1170+
__releases(&cfb->reg_b0_lock)
11691171
{
11701172
cyber2000fb_writew(0x0bf, 0x3ce, cfb);
11711173
spin_unlock(&cfb->reg_b0_lock);

0 commit comments

Comments
 (0)