Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Please review translation.js code #163

Closed
Helkyd opened this issue Jan 20, 2022 · 2 comments
Closed

Please review translation.js code #163

Helkyd opened this issue Jan 20, 2022 · 2 comments

Comments

@Helkyd
Copy link

Helkyd commented Jan 20, 2022

Found # and is returning error

#translate(segment) {
// TODO: implement translation backend
return segment;
}

#stitch() {
if (typeof this.args[0] === 'string') {
return stringReplace(this.args[0], this.args.slice(1));
}

@18alantom
Copy link
Member

18alantom commented Jan 20, 2022

Yup, I realised it when I restarted yarn electron:serve. For whatever reason, it was working when I made the changes whilst yarn electron:serve was running.

The issue seems to be some kinda bug that is preventing babel-loader from being used for transpiling the dependencies.

Due to this and other reasons, I'll be inlining frappejs code into books (the relevant parts): frappe/books#320

@18alantom
Copy link
Member

Closing this cause: #164

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants