Add support for GitHub Enterprise

[slaweet]

It would be useful to be able to connect the extension to an on-premise instance of GitHub Enterprise

I know that another GitHub extension allows that https://github.com/sindresorhus/refined-github

BTW thanks for a great extension 🥇

[fwouts]

Great idea!

It looks like it's almost a one-line change if we just wanted to point PR Monitor to GitHub Enterprise instead of GitHub.

However, I imagine you'd want it to collect PRs from both GitHub and GitHub Enterprise?

Heads-up, this might be a bit tricky to do on my own as I don't have access to GitHub Enterprise. I'll probably need some help from you :)

[slaweet]

Thanks for the quick reply.

However, I imagine you'd want it to collect PRs from both GitHub and GitHub Enterprise?

Currently, I'm working mostly with GitHub Enterprise, so it would be enough for me 🙂

Heads-up, this might be a bit tricky to do on my own as I don't have access to GitHub Enterprise. I'll probably need some help from you :)

I can surely help with that.

[fwouts]

Cheers!

As a first step, would you mind trying out the extension with the one-line change shown in d0f753c (replacing with the correct domain for you)?

There are rudimentary instructions for building the extension locally in the README, let me know if they're insufficient :)

[slaweet]

I tried to follow the install instructions in README. The only thing that was not straight-forward for me was step 4. But Google search helped. I'd suggest to include some link like https://www.cnet.com/how-to/how-to-install-chrome-extensions-manually/ (or some other if you know a better one) into step 4 in README.

Now my problem seems to be that I don't know the GitHub API endpoint of our GitHub Enterprise instance. Given our instance is on https://git.<my_domain>.io, I thought the API would be on https://api.github.<my_domain>.io or https://api.git.<my_domain>.io, but there's nothing. I don't know if the address is configurable or the API can be disabled altogether. I'll ask around at work on Monday and will get back to you 🙂

[fwouts]

Just a random thought. Have you tried https://api.github.git.<my_domain>.io?

[slaweet]

So the API endpoint turned out to be https://git.<my_domain>.io/api/v3.

Changing the baseUrl seems to work perfectly:

I didn't yet have a chance to see a push notification, but I assume there is no reason it wouldn't work.

This solves my situation perfectly - I can run the custom-url extension in addition to the official one connected to GitHub.com

[fwouts]

That's awesome!

It does sound like a good long-term solution... I'd assume GitHub Enterprise users are a bit more security conscious so they'd appreciate having full control of the extension's code anyway.

Let's keep this issue open, and I'll write up some documentation to make it a bit easier for others to follow your lead.

Thanks for giving it a try 🙂

[fwouts]

Instructions added in 97c2e58, so I'll close this off. Feel free to open further issues if you find any bugs with the integration.