Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification filtering #772

Closed
michaelpearce-at opened this issue Jun 4, 2020 · 3 comments · Fixed by #775
Closed

Notification filtering #772

michaelpearce-at opened this issue Jun 4, 2020 · 3 comments · Fixed by #775

Comments

@michaelpearce-at
Copy link

For the vast majority of cases, I am not interested in when the author has added a new commit. I'm interested when they tag me, request a review from me, or comment on a PR which I've been involved in. A large part of my interaction with PR Monitor seems to be "mute until next update from author" when they add a commit (it's especially annoying when it's just that they've merged the latest master into their branch).

A way to select which notifications I'm actually interested in would be nice. This includes the badge on the icon - it should only increase its count for notifications I've selected.

fwouts added a commit that referenced this issue Jun 4, 2020
This is a variant of "Mute until next update" that ignores new commits. See #772.
fwouts added a commit that referenced this issue Jun 4, 2020
This is a variant of "Mute until next update" that ignores new commits. See #772.
@fwouts
Copy link
Owner

fwouts commented Jun 4, 2020

Instead of implementing a whole new notifications preference screen, I opted to add a new muting option. Let me know what you think.

Note: the wording for the second one is now "until any update from author".

Screen Shot 2020-06-05 at 8 40 52 am

@fwouts
Copy link
Owner

fwouts commented Jun 4, 2020

Giving it a bit more thought, this feature isn't quite what you need, because it only affects PRs that you have muted. It won't affect PRs that you have reviewed, and that automatically disappear from "Incoming PRs" because you have reviewed them. I guess we'll need these notification settings after all :)

@michaelpearce-at
Copy link
Author

Ah, that latest commit should do nicely :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants