From c55f7e76b010f9a0b7abcac2b7cfd6155a4236a7 Mon Sep 17 00:00:00 2001 From: Chris O'Brien <57543709+eureka-cpu@users.noreply.github.com> Date: Thu, 6 Jan 2022 13:22:03 -0600 Subject: [PATCH] clippy doesn't fail on warnings (#583) * clippy doesn't fail on warnings * Update clippy_check.yml * fixed lints --- .github/workflows/clippy_check.yml | 2 +- sway-core/src/semantic_analysis/namespace.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/clippy_check.yml b/.github/workflows/clippy_check.yml index e6cc2c3dd03..2ed7dcd5685 100644 --- a/.github/workflows/clippy_check.yml +++ b/.github/workflows/clippy_check.yml @@ -15,4 +15,4 @@ jobs: uses: actions-rs/clippy-check@v1.0.7 with: token: ${{ github.token }} - args: --all-features + args: --all-features -- -D warnings diff --git a/sway-core/src/semantic_analysis/namespace.rs b/sway-core/src/semantic_analysis/namespace.rs index 8bfc69aeacb..7ac3e5c71f5 100644 --- a/sway-core/src/semantic_analysis/namespace.rs +++ b/sway-core/src/semantic_analysis/namespace.rs @@ -150,7 +150,7 @@ impl Namespace { } } } - self.symbols.insert(name.clone(), item.clone()); + self.symbols.insert(name, item); ok((), warnings, errors) }