Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data libraries - missing features #1177

Open
10 of 18 tasks
bgruening opened this issue Nov 26, 2015 · 22 comments
Open
10 of 18 tasks

New data libraries - missing features #1177

bgruening opened this issue Nov 26, 2015 · 22 comments

Comments

@bgruening
Copy link
Member

bgruening commented Nov 26, 2015

Since the old data library is deprecated I ask on our mailing list about features that are missing from the new data library interface.

  • Rename and modify folders

  • Move folders and datasets inside a library and to another library (preferably drag/drop)

  • When modifying permissions as non-admin user, expose_user_name and expose_user_email config options are not respected

  • Edit library dataset information: datatype, genome build, info, message

  • Upload folder and datasets to a new history (see Allowing Library datasets to be uploaded to a new history #1265)

  • Make searching recursive (see data libraries subsearch #1045)

  • Display the "message" field when browsing (see display 'message' field in data libraries #1570)

  • Select all datasets button when importing (Library import from FTP interface needs "select all" option #1606)

  • Import a data library folder as a collection (see Import Data Library Folder as Collection #2108)

  • Handle form definitions attached to library datasets (allow modification?; import?; ignore?; replace?)

  • Option to symlink individual files when uploading (see Feature request - symlink files when uploading data to data library using the "from user directory" option #1529)

  • Show the state of the upload job of library datasets

  • Ability to order library contents based on columns

  • Cannot set "read" access permission on a folder, must set individually on files within that folder.

  • Cannot share datasets with individual users. I must have a "sharing role" available (I could create these once by sharing a history with a user, but no more?), or by have a normal role available.

  • Cannot share LDAs with multiple roles.

    User has to have all these roles in order to access this dataset. Users without access permission cannot have other permissions on this dataset. If there are no access roles set on the dataset it is considered unrestricted.

    Is absolutely useless to me, I want to share with multiple roles without creating a super-role just for the purpose for sharing with a set of groups.

  • Be an admin. Modify: Role B, Access: Role A, Manage: Role B. Save. All modified roles disappear except for "Access"

  • Ensure that documentation and functionality is consistent and clear. In some places sharing is done via username / email (histories, etc), whilst in other places it is done via roles. These have extremely different behaviours despite similar appearance. Sharing to histories can be done even without expose_username/email. Sharing libraries works via roles and does not allow pasting in an email. We should unify sharing xref Rework the sharing system of Galaxy objects #4602

@nsoranzo nsoranzo changed the title New data library - missing featuers New data library - missing features Nov 26, 2015
@martenson martenson self-assigned this Nov 26, 2015
@nsoranzo
Copy link
Member

I have added an extra point to the description, i.e. "when modifying permissions as non-admin user, expose_user_name and expose_user_email config options are not respected".

@nsoranzo
Copy link
Member

I've also reworded the second point to mention that it would be nice to move folders and datasets from a library to another.

@nsoranzo
Copy link
Member

nsoranzo commented Dec 8, 2015

I've found another regression with respect to the deprecated library interface, it's not possible to edit library dataset information: datatype, genome build, info, message. Added to the list.

@nsoranzo
Copy link
Member

nsoranzo commented Dec 8, 2015

I've merged #1265 here.

@martenson martenson changed the title New data library - missing features New data libraries - missing features Dec 15, 2015
@martenson martenson modified the milestones: 16.04, 16.01 Jan 6, 2016
@bwlang
Copy link
Contributor

bwlang commented Jan 13, 2016

Since it looks like this is the new spot for data library missing features before the deprecated lib manager can be removed.

  • import from user directory on nfs mount with many folders is unusable (never populates list or takes 30+ minutes)
  • As Björn mentions, need to be able to move files (preferably drag/drop)
  • report sizes of subtrees
  • editing names, tags, meta-data of both folders and files

Other (IMHO) important features

  • add disk space used to user quotas
  • search

@martenson
Copy link
Member

@bwlang I am not surprised that import with the file browser is unusable when you need to browse 1000s of files, but importing using the path should still work decently. Are you also having problem using path import?

Thank you for all the suggestions!

@bwlang
Copy link
Contributor

bwlang commented Jan 13, 2016

Path import works great... But I don't think it a good option for end users
On Jan 13, 2016 4:15 PM, "Martin Cech" [email protected] wrote:

@bwlang https://github.com/bwlang I am not surprised that import with
the file browser is unusable, but importing using the path should still
work decently. Are you also having problem using path import?

Thank you for all the suggestions!


Reply to this email directly or view it on GitHub
#1177 (comment)
.

@martenson
Copy link
Member

@bwlang no it is not (it is meant for admins), but building reliable user-facing web UI for async browsing potentially huge network-connected storage filesystem is probably not a task we want to undercome :/

In my thinking the file library import file browser is targeted at users importing from their own FTP folder after they uploaded files to the instance.

@bwlang
Copy link
Contributor

bwlang commented Jan 14, 2016

One layer is deep enough for me... No need to see the whole tree.

Do you think a find -maxdepth 1 would do it?

Brad

On Wednesday, January 13, 2016, Martin Cech [email protected]
wrote:

@bwlang https://github.com/bwlang no it is not, but building reliable
web UI for async browsing potentially huge network-connected storage
filesystem is probably not a task we want to undercome :/


Reply to this email directly or view it on GitHub
#1177 (comment)
.

@gregvonkuster
Copy link
Contributor

Not sure of the voting process, but +1 on adding these important missing features!

@pavanvidem
Copy link
Member

I just found this issue here, not moving files around is really a regression.

@bgruening
Copy link
Member Author

👍 The old data libraries stopped working for us, it's just too large.

@sarah-peter
Copy link

I just commented on #1529 and also want to add my +1 here. The options to link individual files and move datasets are really important in my opinion and I have used them a lot in the past.

@gregvonkuster
Copy link
Contributor

+1 from me as well for being able to link individual files.

@sarah-peter
Copy link

The old data libraries did also dereference links once when linking files instead of copying. This was very useful for cases like this: https://biostar.usegalaxy.org/p/1297/.

I'm wondering why you decided to completely drop the old interface, when there are still so many features missing from the new one. They existed in parallel for a long time, so why not just switch the default, but keep the old one until all features are implemented?

Are there any plans to implement the missing features or a timeline?

@hexylena
Copy link
Member

hexylena commented Jun 2, 2017

added another bullet point. Are there any of these we can cross off? Would be nice since the old one is now deprecated.

@bgruening
Copy link
Member Author

I think @mvdbeek fixed one in #3559.

@hexylena
Copy link
Member

hexylena commented Jun 2, 2017

I think that is the other way, collection -> library, not library -> collection as is in the list in the issue.

@chambm
Copy link
Contributor

chambm commented Jun 8, 2017

Right , I found that I could add a collection to a library in 17.05, but it only added them as individual datasets. It'd be far better if the collection was itself presented as a folder and when adding it to a history, it kept its collection status.

@martenson
Copy link
Member

I am currently chewing through the list (you can track progress here).

One thing I am pretty sure I would like to completely cut off is libraries using form definitions. If you have a good use case and/or use it heavily, please comment here.

@scholtalbers
Copy link
Contributor

I just spend some time tracking down an issue as to why a certain workflow would not run (the editor complained about some At least 2 datasets are required. Using default: ''. so I looked in the wrong direction..).
It turned out that the users trying to use the workflow, me included, were admins and we imported a shared .gtf file from a data library assuming it was publicly available. Only in the handler logs I saw the message galaxy.tools.execute WARNING 2017-09-27 15:29:26,476 There was a failure executing a job for tool [NFS_transfer] - Error executing tool: User does not have permission to use a dataset (1204) provided for input., indicating this was a protected dataset.

In this case, there are a few options to remedy:

  1. the admin user should not be able to import and use the dataset in the tool form
  2. a clear warning should show up when trying to import
  3. allow the admin to use the dataset as tool input ignoring the permission set on the dataset

@scholtalbers
Copy link
Contributor

(Still) missing as admin:

  • path of linked datasets ("Disk file:")
  • ability to upload a dataset directly i.e. "upload files"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests