diff --git a/Directory.Build.props b/Directory.Build.props index 0b999b18d37db..1be78d8e4ea4d 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -88,6 +88,9 @@ false + + + diff --git a/docs/coding-guidelines/project-guidelines.md b/docs/coding-guidelines/project-guidelines.md index e1ede65ea60b9..5ab9a76c1573f 100644 --- a/docs/coding-guidelines/project-guidelines.md +++ b/docs/coding-guidelines/project-guidelines.md @@ -10,9 +10,9 @@ once before you can iterate and work on a given library project. - Netstandard Library - Copy to `bin\ref\netstandard2.0` - NetFx targeting pack - Copy to `bin\ref\net472` - Build targeting pack - - Build src\ref.builds which builds all references assembly projects. For reference assembly project information see [ref](#ref) + - Build src\libraries\ref.proj which builds all references assembly projects. For reference assembly project information see [ref](#ref) - Build product - - Build src\src.builds which builds all the source library projects. For source library project information see [src](#src). + - Build src\libraries\src.proj which builds all the source library projects. For source library project information see [src](#src). - Sign product - Build src\sign.proj diff --git a/eng/Analyzers.props b/eng/Analyzers.props index 534d38a5546ca..034bb1b8e49c6 100644 --- a/eng/Analyzers.props +++ b/eng/Analyzers.props @@ -1,6 +1,8 @@ $(MSBuildThisFileDirectory)CodeAnalysis.ruleset + + false diff --git a/eng/Build.props b/eng/Build.props index 95f52b37593d4..8827b98cd3642 100644 --- a/eng/Build.props +++ b/eng/Build.props @@ -15,6 +15,7 @@ https://github.com/dotnet/arcade/issues/388 --> + @@ -76,8 +77,12 @@ + Properties="Configuration=Debug;Platform=AnyCPU;__BuildPhase=Restore" + Targets="Restore" /> + + + + + + $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'libraries')) + $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'coreclr')) + $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'mono')) + $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'installer')) + $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'tools-local')) + $([MSBuild]::NormalizeDirectory('$(RepoToolsLocalDir)', 'tasks')) + $([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'ibc')) + $([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'docs')) + + + + true + + $(Configuration) diff --git a/eng/Subsets.props b/eng/Subsets.props index 6939ee71af00b..90346437faa14 100644 --- a/eng/Subsets.props +++ b/eng/Subsets.props @@ -47,15 +47,6 @@ artifacts to the test layout, then running the test subset. --> - - $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'libraries')) - $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'coreclr')) - $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'mono')) - $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'installer')) - $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'tools-local')) - $([MSBuild]::NormalizeDirectory('$(RepoToolsLocalDir)', 'tasks')) - - libraries-installer-coreclr-mono corehost-managed-depproj-pkgproj-bundle-installers-test diff --git a/eng/Tools.props b/eng/Tools.props index 4c399288ad250..999758d5f8f94 100644 --- a/eng/Tools.props +++ b/eng/Tools.props @@ -1,39 +1,13 @@ - - false - true - + + - - - - - - - - - - - - - - - - - - - - - - - diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index e2b20bc565a85..6174024211e1d 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -38,13 +38,13 @@ https://github.com/dotnet/arcade 421b20fb860907c45673de791177e3fd61402197 - + https://github.com/dotnet/arcade 421b20fb860907c45673de791177e3fd61402197 - + https://github.com/dotnet/arcade - 421b20fb860907c45673de791177e3fd61402197 + bc4fa8e7149769db4efd466f160417a32b11f0bf https://github.com/dotnet/arcade diff --git a/eng/Versions.props b/eng/Versions.props index e7bd40414e24d..eadba34548364 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -19,10 +19,6 @@ true true false - - true - $([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'ibc')) - $([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'docs')) dotnet $(ContainerName) @@ -60,7 +56,7 @@ 5.0.0-beta.20153.1 5.0.0-beta.20153.1 - 5.0.0-beta.20153.1 + 5.0.0-beta.20156.4 5.0.0-beta.20153.1 5.0.0-beta.20153.1 5.0.0-beta.20153.1 diff --git a/eng/codeAnalysis.targets b/eng/codeAnalysis.targets deleted file mode 100644 index de4eb79cd35db..0000000000000 --- a/eng/codeAnalysis.targets +++ /dev/null @@ -1,51 +0,0 @@ - - - - - - - - - - - - - - <_AnalyzersToFileName Include="@(Analyzer -> '%(FileName)')"> - %(Identity) - - - - - <_AnalyzersToRemove Include="@(_AnalyzersToFileName)" Condition="'@(AnalyzersToExclude)' == '@(_AnalyzersToFileName)' and '%(Identity)' != ''" /> - - - - - <_AnalyzersToRemove Include="@(_AnalyzersToFileName)" Exclude="@(AnalyzersToInclude)" /> - <_missingAnalyzersToInclude Include="@(AnalyzersToInclude)" Exclude="@(_AnalyzersToFileName)" /> - - - - - - - - - $(ResolveReferencesDependsOn); - CalculateAnalyzersForBuildTime; - - - \ No newline at end of file diff --git a/eng/docker/build-docker-sdk.ps1 b/eng/docker/build-docker-sdk.ps1 index 76c1ce7b41407..af1943a0d49dc 100755 --- a/eng/docker/build-docker-sdk.ps1 +++ b/eng/docker/build-docker-sdk.ps1 @@ -18,8 +18,7 @@ if ($buildWindowsContainers) # Due to size concerns, we don't currently do docker builds on windows. # Build on the host machine, then simply copy artifacts to the target docker image. # This should result in significantly lower build times, for now. - & "$REPO_ROOT_DIR/coreclr.cmd" -c Release - & "$REPO_ROOT_DIR/libraries.cmd" -ci -c $configuration -runtimeConfiguration release + & "$REPO_ROOT_DIR/build.cmd" -ci -subsetcategory coreclr-libraries -runtimeconfiguration release -c $configuration # Dockerize the build artifacts docker build --tag $imageName ` diff --git a/eng/docker/libraries-sdk.linux.Dockerfile b/eng/docker/libraries-sdk.linux.Dockerfile index efba4fb7c309d..fce6381e71028 100644 --- a/eng/docker/libraries-sdk.linux.Dockerfile +++ b/eng/docker/libraries-sdk.linux.Dockerfile @@ -8,8 +8,7 @@ WORKDIR /repo COPY . . ARG CONFIGURATION=Release -RUN ./src/coreclr/build.sh -release -skiptests -clang9 && \ - ./libraries.sh -c $CONFIGURATION -runtimeconfiguration release +RUN ./build.sh -ci -subsetcategory coreclr-libraries -runtimeconfiguration release -c $CONFIGURATION FROM $SDK_BASE_IMAGE as target diff --git a/eng/pipelines/libraries/enterprise/linux.yml b/eng/pipelines/libraries/enterprise/linux.yml index 4cf1c7ded3827..017ca39dbb0cc 100644 --- a/eng/pipelines/libraries/enterprise/linux.yml +++ b/eng/pipelines/libraries/enterprise/linux.yml @@ -26,7 +26,7 @@ variables: - name: enterpriseTestsSetup value: $(sourcesRoot)/Common/tests/System/Net/EnterpriseTests/setup - name: containerRunTestsCommand - value: /repo/.dotnet/dotnet build /t:test --no-restore + value: /repo/.dotnet/dotnet build /t:test - name: containerLibrariesRoot value: /repo/src/libraries @@ -50,7 +50,7 @@ steps: displayName: Test linuxclient connection to web server - bash: | - docker exec linuxclient bash -c '/repo/src/coreclr/build.sh -release -skipnuget -clang9 && /repo/libraries.sh /p:CoreCLRConfiguration=Release' + docker exec linuxclient bash -c '/repo/build.sh -subsetcategory coreclr-libraries -runtimeconfiguration release -ci' displayName: Build product sources - bash: | diff --git a/src/libraries/restore/harvestPackages/harvestPackages.depproj b/eng/restore/harvestPackages.targets similarity index 54% rename from src/libraries/restore/harvestPackages/harvestPackages.depproj rename to eng/restore/harvestPackages.targets index 2ae20ecda6e67..d6f6f98019f1c 100644 --- a/src/libraries/restore/harvestPackages/harvestPackages.depproj +++ b/eng/restore/harvestPackages.targets @@ -1,15 +1,14 @@ - + - netstandard2.0 + $(NuGetPackageRoot)microsoft.dotnet.build.tasks.packaging\$(MicrosoftDotNetBuildTasksPackagingVersion)\tools\ + $(PackagingTaskAssembly)netcoreapp2.1\ + $(PackagingTaskAssembly)net472\ + $(PackagingTaskAssembly)Microsoft.DotNet.Build.Tasks.Packaging.dll - - - - + + <_AllPkgProjs Include="$(LibrariesProjectRoot)*\pkg\**\*.pkgproj" /> @@ -20,10 +19,10 @@ - + LatestPackages="@(_AllPkgProjsToPackageIdentity)" + PackageIndexes="$(PackageIndexFile)" + DoNotAllowVersionsFromSameRelease="true"> + @@ -40,5 +39,4 @@ - \ No newline at end of file diff --git a/eng/restore/repoRestore.props b/eng/restore/repoRestore.props index 204c23d1de0b9..3d6a393519d7f 100644 --- a/eng/restore/repoRestore.props +++ b/eng/restore/repoRestore.props @@ -28,4 +28,4 @@ false false - \ No newline at end of file + diff --git a/eng/restore/repoRestore.targets b/eng/restore/repoRestore.targets index d99f198e1a5fb..a430b67fee1ff 100644 --- a/eng/restore/repoRestore.targets +++ b/eng/restore/repoRestore.targets @@ -4,8 +4,6 @@ Unknown - - @@ -146,6 +140,14 @@ $(RepositoryEngineeringDir)DefaultGenApiDocIds.txt + + + + + + + + <_runtimeOSVersionIndex>$(RuntimeOS.IndexOfAny(".-0123456789")) <_runtimeOSFamily Condition="'$(_runtimeOSVersionIndex)' != '-1'">$(RuntimeOS.SubString(0, $(_runtimeOSVersionIndex))) @@ -170,6 +172,7 @@ win-x64 osx-x64 linux-x64 + $(ToolRuntimeRID) <_portableOS Condition="'$(TargetOS)' == 'Unix' and '$(_runtimeOSFamily)' != 'osx' and '$(_runtimeOSFamily)' != 'FreeBSD' and '$(_runtimeOS)' != 'linux-musl'">linux @@ -268,10 +271,10 @@ strict;nullablePublicOnly 4 true - + false true - true + true @@ -296,7 +299,6 @@ $([MSBuild]::NormalizeDirectory('$(RefRootPath)', 'netstandard2.0')) $([MSBuild]::NormalizeDirectory('$(RefRootPath)', 'netstandard2.1')) $([MSBuild]::NormalizeDirectory('$(RefRootPath)', '$(NetFrameworkCurrent)')) - $([MSBuild]::NormalizeDirectory('$(ArtifactsToolsetDir)', 'ilasm')) $(TargetOS).$(Platform).$(Configuration) @@ -335,6 +337,12 @@ + + true + + + + false true diff --git a/src/libraries/Directory.Build.targets b/src/libraries/Directory.Build.targets index 659009ab0dbe2..f019b5bd21a6a 100644 --- a/src/libraries/Directory.Build.targets +++ b/src/libraries/Directory.Build.targets @@ -113,7 +113,6 @@ - diff --git a/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft.VisualBasic.Core.vbproj b/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft.VisualBasic.Core.vbproj index 436ecca9fbe2d..e8774341649ca 100644 --- a/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft.VisualBasic.Core.vbproj +++ b/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft.VisualBasic.Core.vbproj @@ -18,6 +18,8 @@ + + false $(NetCoreAppCurrent);$(NetCoreAppCurrent)-Windows_NT diff --git a/src/libraries/System.Net.Http/src/PInvokeAnalyzerExceptionList.analyzerdata b/src/libraries/System.Net.Http/src/PinvokeAnalyzerExceptionList.analyzerdata similarity index 100% rename from src/libraries/System.Net.Http/src/PInvokeAnalyzerExceptionList.analyzerdata rename to src/libraries/System.Net.Http/src/PinvokeAnalyzerExceptionList.analyzerdata diff --git a/src/libraries/System.Runtime.WindowsRuntime/ref/System.Runtime.WindowsRuntime.csproj b/src/libraries/System.Runtime.WindowsRuntime/ref/System.Runtime.WindowsRuntime.csproj index 08655bbddfe08..ee65f5e9eff93 100644 --- a/src/libraries/System.Runtime.WindowsRuntime/ref/System.Runtime.WindowsRuntime.csproj +++ b/src/libraries/System.Runtime.WindowsRuntime/ref/System.Runtime.WindowsRuntime.csproj @@ -18,13 +18,13 @@ - + - + diff --git a/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj b/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj index 60f7f32e4794b..147afba607288 100644 --- a/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj +++ b/src/libraries/System.Runtime.WindowsRuntime/src/System.Runtime.WindowsRuntime.csproj @@ -15,18 +15,6 @@ SR.PlatformNotSupported_WindowsRuntime true - - - - - - - - - - - - @@ -94,12 +82,24 @@ Common\System\HexConverter.cs + + + + + + + + + + + + - + diff --git a/src/libraries/System.Runtime.WindowsRuntime/tests/System.Runtime.WindowsRuntime.Tests.csproj b/src/libraries/System.Runtime.WindowsRuntime/tests/System.Runtime.WindowsRuntime.Tests.csproj index dab72ed0560b0..8633fffda010c 100644 --- a/src/libraries/System.Runtime.WindowsRuntime/tests/System.Runtime.WindowsRuntime.Tests.csproj +++ b/src/libraries/System.Runtime.WindowsRuntime/tests/System.Runtime.WindowsRuntime.Tests.csproj @@ -18,6 +18,6 @@ - + \ No newline at end of file diff --git a/src/libraries/build.proj b/src/libraries/build.proj index 8da5cf9b63eb6..0e00e66aea450 100644 --- a/src/libraries/build.proj +++ b/src/libraries/build.proj @@ -11,21 +11,32 @@ $(BuildDependsOn);BuildManaged $(BuildDependsOn);Pack $(BuildDependsOn);BuildTests + + true - <_RestoreProjects Include="$(MSBuildThisFileDirectory)restore\dirs.proj" Build="true" /> + <_RestoreBuildProjects Include="$(MSBuildThisFileDirectory)restore\dirs.proj" /> + <_RestoreProjects Include="@(_RestoreBuildProjects)" /> - - - <_RestoreProjects Include="$(MSBuildThisFileDirectory)tests.proj" Build="false" /> + + + <_RestoreProjects Include="$(MSBuildThisFileDirectory)dirs.proj" /> + <_RestoreProjects Include="$(MSBuildThisFileDirectory)tests.proj" Condition="'$(DotNetBuildFromSource)' != 'true'" /> + <_RestoreProjects Include="$(MSBuildThisFileDirectory)packages.proj" /> - - + + + @@ -33,7 +44,7 @@ <_BuildNativeProjects Include="$(MSBuildThisFileDirectory)Native\build-native.proj" /> - + @@ -41,7 +52,15 @@ <_BuildMangedProjects Include="$(MSBuildThisFileDirectory)dirs.proj" /> - + + + + @@ -49,9 +68,15 @@ <_TestProjects Include="$(MSBuildThisFileDirectory)tests.proj" /> + + Condition="'$(RestoreAll)' != 'true'" + Properties="__BuildPhase=Restore" + Targets="Restore" /> + + @@ -60,16 +85,23 @@ + Targets="Test" /> - <_PackProjects Include="$(MSBuildThisFileDirectory)packages.builds" /> + <_PackProjects Include="$(MSBuildThisFileDirectory)packages.proj" /> - + + + + diff --git a/src/libraries/dirs.proj b/src/libraries/dirs.proj index 2b9534d5965a8..d03d5892fe792 100644 --- a/src/libraries/dirs.proj +++ b/src/libraries/dirs.proj @@ -1,26 +1,35 @@ - + - - true + $(BuildTargetFramework) - - - - - - - + + + + + + - - + + - + - \ No newline at end of file + + + + + + diff --git a/src/libraries/packages.builds b/src/libraries/packages.proj similarity index 71% rename from src/libraries/packages.builds rename to src/libraries/packages.proj index ab33fce628208..9e62eb26d72bf 100644 --- a/src/libraries/packages.builds +++ b/src/libraries/packages.proj @@ -1,23 +1,22 @@ - + + true + + + - - $(AdditionalBuildTargetFrameworks);package-$(Configuration) + + $(BuildTargetFramework) + $(AdditionalBuildTargetFrameworks);package-$(Configuration) - - $(AdditionalProperties) - - - $(AdditionalProperties) - + + - - - + + + + + diff --git a/src/libraries/pretest.proj b/src/libraries/pretest.proj index 317bf140a39af..5b5cb13dd2490 100644 --- a/src/libraries/pretest.proj +++ b/src/libraries/pretest.proj @@ -2,16 +2,15 @@ + $(BuildTargetFramework) GenerateLaunchSettingsFiles $(BuildDependsOnTargets);GenerateTestSharedFrameworkDepsFile $(BuildDependsOnTargets);GenerateFileVersionProps - netcoreapp - 5.0 - + @@ -58,6 +57,7 @@ <_TestProjectRootDir>$(LibrariesProjectRoot) <_TestProjectRootDir Condition="'$(DirectoryToBuild)'!=''">$(DirectoryToBuild) + @@ -65,7 +65,7 @@ + ContinueOnError="ErrorAndStop" /> @@ -73,15 +73,9 @@ - - - - - diff --git a/src/libraries/ref.builds b/src/libraries/ref.builds deleted file mode 100644 index 9bef0a6e4edba..0000000000000 --- a/src/libraries/ref.builds +++ /dev/null @@ -1,14 +0,0 @@ - - - - - - - - - - - - - - diff --git a/src/libraries/ref.proj b/src/libraries/ref.proj new file mode 100644 index 0000000000000..99037969eaadb --- /dev/null +++ b/src/libraries/ref.proj @@ -0,0 +1,30 @@ + + + + + $(BuildTargetFramework) + + + + + + + + + + + + + + + + + + + + + + diff --git a/src/libraries/restore/analyzers/analyzers.depproj b/src/libraries/restore/analyzers/analyzers.depproj deleted file mode 100644 index 27fad4d37cff1..0000000000000 --- a/src/libraries/restore/analyzers/analyzers.depproj +++ /dev/null @@ -1,27 +0,0 @@ - - - false - true - C# - netstandard2.0 - - - - - - - - - - - - - - diff --git a/src/libraries/restore/dirs.proj b/src/libraries/restore/dirs.proj index d54794d38db3e..ee2162758d1e6 100644 --- a/src/libraries/restore/dirs.proj +++ b/src/libraries/restore/dirs.proj @@ -1,15 +1,14 @@ - - + + $(BuildTargetFramework) + - - + + - - diff --git a/src/libraries/restore/tools/tools.depproj b/src/libraries/restore/tools/tools.depproj deleted file mode 100644 index f2e32a3773b8b..0000000000000 --- a/src/libraries/restore/tools/tools.depproj +++ /dev/null @@ -1,18 +0,0 @@ - - - $(ILAsmToolPath) - false - $(ToolRuntimeRID) - $(NoWarn);NU1603;NU1605 - netstandard2.0 - - - - - $(MicrosoftNETCoreILAsmVersion) - - - $(MicrosoftNETCoreILAsmVersion) - - - \ No newline at end of file diff --git a/src/libraries/restore/winrt/winrt.depproj b/src/libraries/restore/winrt/winrt.depproj deleted file mode 100644 index fb99977c302e5..0000000000000 --- a/src/libraries/restore/winrt/winrt.depproj +++ /dev/null @@ -1,16 +0,0 @@ - - - Windows - .winmd - - true - Reference - netcoreapp3.0;$(netcoreappCurrent);netstandard1.0 - - - - 1.0.5 - - - \ No newline at end of file diff --git a/src/libraries/shims/ApiCompat.proj b/src/libraries/shims/ApiCompat.proj index a340a3d1a5aec..db4c9fe1d756e 100644 --- a/src/libraries/shims/ApiCompat.proj +++ b/src/libraries/shims/ApiCompat.proj @@ -1,9 +1,12 @@ - + + - + + $(BuildTargetFramework) + - $(BuildTargetFramework) + $(TargetFramework) netcoreapp $(IntermediateOutputPath)/apicompat.rsp $(MSBuildThisFileDirectory)ApiCompatBaseline.$(ApiCompatTarget).netfx461.txt @@ -98,11 +101,12 @@ - - + - - + + + + diff --git a/src/libraries/shims/Directory.Build.props b/src/libraries/shims/Directory.Build.props index 790b6126ca80d..768825eb3e775 100644 --- a/src/libraries/shims/Directory.Build.props +++ b/src/libraries/shims/Directory.Build.props @@ -1,4 +1,7 @@ + + true + diff --git a/src/libraries/src.builds b/src/libraries/src.builds deleted file mode 100644 index 5903b7fd7a10a..0000000000000 --- a/src/libraries/src.builds +++ /dev/null @@ -1,21 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - diff --git a/src/libraries/src.proj b/src/libraries/src.proj new file mode 100644 index 0000000000000..d2d0ec88d23df --- /dev/null +++ b/src/libraries/src.proj @@ -0,0 +1,34 @@ + + + + + $(BuildTargetFramework) + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index d47a26ac972b8..1a32a6b477c38 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -1,9 +1,9 @@ - + - $(NetCoreAppCurrent) + $(BuildTargetFramework) @@ -14,22 +14,16 @@ - - - - + + + + - + - - - - - - + - - - @@ -58,13 +50,13 @@ -