Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: Selected theme not loaded when refreshing #1984

Closed
HTTPHeader opened this issue Feb 19, 2025 · 1 comment
Closed

Bug report: Selected theme not loaded when refreshing #1984

HTTPHeader opened this issue Feb 19, 2025 · 1 comment
Labels

Comments

@HTTPHeader
Copy link

HTTPHeader commented Feb 19, 2025

Describe the bug
When I select a theme, upon refreshing, it always applies the dark one. (CyberChef public website)

To Reproduce
Steps to reproduce the behaviour or a link to the recipe / input used to cause the bug:

  1. Go to 'Options'
  2. Click on 'Theme' drop-down list
  3. Select any other theme than the default one.
  4. Click 'Close'
  5. Refresh the page

Expected behaviour
Upon refreshing, the selected theme should load.

Actual behaviour
The dark theme always gets loaded.

Screenshots
bug

Desktop (if relevant, please complete the following information):

  • Browsers tested on: Firefox Developer 136.0b7 (aarch64), Google Chrome 133.0.6943.55 (arm64)
  • CyberChef version: 10.19.4

Additional context
The theme JSON value in the browser's local storage is indeed set, but CyberChef won't load it.

@HTTPHeader HTTPHeader added the bug label Feb 19, 2025
@HTTPHeader HTTPHeader changed the title Bug report: Saved theme not loaded Bug report: Selected theme not loaded when refreshing Feb 19, 2025
@HTTPHeader
Copy link
Author

HTTPHeader commented Feb 19, 2025

figured out that the gh page version differs from the release. seems like its reading my browsers preference for theme (dark, light) and applies it automatically. so far, the only fix i found was to add a script override and place the same code in main.js as in the release version. this will probably get fixed so i'll close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant