* New EventAI Events (EVENT_T_TARGET_HP, EVENT_T_TARGET_CASTING). New Cast flags (CAST_NO_MELEE_IF_OOM, CAST_FORCE_TARGET_SELF). Please read EventAI.txt

* Prevent crash in C'thun if no instance script. Boss will just not react to anything if instance script not set.

* Possibly fix Karathress.

* Add triggered bool to CanCast function.

git-svn-id: https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2@383 5f9c896b-1e26-0410-94da-f77f675e2462

Author: Ntsc

docs/EventAI.txt

@@ -63,6 +63,8 @@ Params are always read from Param1, then Param2, then Param3.
 11   EVENT_T_RANGE               MinDist, MaxDist, TimeUnitlRepeat      Expires when the highest threat target distance is greater than (Param1) and less than (Param2). Repeats every (Param3) or never if Param3 = 0.
 12   EVENT_T_OOC_LOS             NoHostile, NoFriendly, TimeUntilRepeat Expires when a Player moves within visible distance to creature. Does not expire for Hostile Players if (Param1) is not 0. Does not expire for Friendly Players if (Param2) is not 0. Will repeat every (Param3) or never if Param3 = 0. Does not expire for creatures or pet or when the creature is in combat.
 13   EVENT_T_SPAWNED             NONE                                   Expires at initial spawn and at creature respawn (useful for setting ranged movement type)
+14   EVENT_T_TARGET_HP           HPMax%, HPMin%, TimeUntilRepeat        Expires when Current Target's HP is between (Param1) and (Param2). Will repeat every (Param3) or never repeat if Param3 = 0. 
+15   EVENT_T_TARGET_CASTING      TimeUntilRepeat			Expires when the player is casting a spell. Will repeat every (Param1) or never repeat if Param1 = 0.
 
 -----------------------------------------
 Action Types
@@ -128,9 +130,11 @@ Cast Flags
 -----------------------------------------
 Below is the list of current Cast Flags that EventAI's spell casting can handle.
 Cast flags are handled bitwise. Bit 0 is Interrupt Previous, bit 1 is triggered, etc.
-So for example the number "3"(11 in binary) would mean that this cast should both interrupt previous and triggered spell.
+So for example the number "3"(11 in binary) would mean that this cast has both CAST_INTURRUPT_PREVIOUS and CAST_TRIGGERED.
 
 (bit#   Internal Name                  Discription)
 0       CAST_INTURRUPT_PREVIOUS        Interrupts any previous spell casting (basicaly makes sure that this spell goes off)
 1       CAST_TRIGGERED                 Forces the spell to be instant cast and require no mana/reagents.
-2       CAST_FORCE_CAST                Forces spell to cast even if the player is possibly out of range or the creature is possibly out of mana
+2       CAST_FORCE_CAST                Forces spell to cast even if the target is possibly out of range or the creature is possibly out of mana
+3       CAST_NO_MELEE_IF_OOM           Prevents creature from entering melee if out of mana or out of range
+4       CAST_FORCE_TARGET_SELF         Forces the target to cast this spell on itself

include/sc_creature.cpp

@@ -325,18 +325,18 @@ SpellEntry const* ScriptedAI::SelectSpell(Unit* Target, int32 School, int32 Mech
     return Spell[rand()%SpellCount];
 }
 
-bool ScriptedAI::CanCast(Unit* Target, SpellEntry const *Spell)
+bool ScriptedAI::CanCast(Unit* Target, SpellEntry const *Spell, bool Triggered)
 {
     //No target so we can't cast
     if (!Target || !Spell)
         return false;
 
     //Silenced so we can't cast
-    if (m_creature->HasFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_SILENCED))
+    if (!Triggered && m_creature->HasFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_SILENCED))
         return false;
 
     //Check for power
-    if (m_creature->GetPower((Powers)Spell->powerType) < Spell->manaCost)
+    if (!Triggered && m_creature->GetPower((Powers)Spell->powerType) < Spell->manaCost)
         return false;
 
     SpellRangeEntry const *TempRange = NULL;

include/sc_creature.h

@@ -157,7 +157,7 @@ struct MANGOS_DLL_DECL ScriptedAI : public CreatureAI
     SpellEntry const* SelectSpell(Unit* Target, int32 School, int32 Mechanic, SelectTarget Targets,  uint32 PowerCostMin, uint32 PowerCostMax, float RangeMin, float RangeMax, SelectEffect Effect);
 
     //Checks if you can cast the specified spell
-    bool CanCast(Unit* Target, SpellEntry const *Spell);
+    bool CanCast(Unit* Target, SpellEntry const *Spell, bool Triggered = false);
 };
 
 

scripts/creature/mob_event_ai.cpp

@@ -87,7 +87,10 @@ struct MANGOS_DLL_DECL Mob_EventAI : public ScriptedAI
         if ( m_creature->Attack(pTarget) )
         {
             if (Follow)
+            {
+                m_creature->GetMotionMaster()->Clear(false);
                 m_creature->GetMotionMaster()->Mutate(new TargetedMovementGenerator<Creature>(*pTarget, AttackDistance, AttackAngle));
+            }
 
             m_creature->AddThreat(pTarget, 0.0f);
             m_creature->resetAttackTimer();
@@ -251,6 +254,33 @@ struct MANGOS_DLL_DECL Mob_EventAI : public ScriptedAI
             {
             }
             break;
+        case EVENT_T_TARGET_HP:
+            {
+                if (!InCombat || !m_creature->getVictim() || !m_creature->getVictim()->GetMaxHealth())
+                    return;
+
+                uint32 perc = (m_creature->getVictim()->GetHealth()*100) / m_creature->getVictim()->GetMaxHealth();
+
+                if (perc > param1 || perc < param2)
+                    return;
+
+                //Prevent repeat for param3 time, or disable if param3 not set
+                if (param3)
+                    pHolder.Time = param3;
+                else pHolder.Enabled = false;
+            }
+            break;
+        case EVENT_T_TARGET_CASTING:
+            {
+                if (!InCombat || !m_creature->getVictim() || !m_creature->getVictim()->IsNonMeleeSpellCasted(false, false, true))
+                    return;
+
+                //Prevent repeat for param1 time, or disable if param3 not set
+                if (param1)
+                    pHolder.Time = param1;
+                else pHolder.Enabled = false;
+            }
+            break;
         default:
             error_log("Event type missing from ProcessEvent() Switch . Type = %d", pHolder.Event.event_type);
             break;
@@ -383,20 +413,45 @@ struct MANGOS_DLL_DECL Mob_EventAI : public ScriptedAI
         case ACTION_T_CAST:
             {
                 Unit* target = GetTargetByType(param2, pActionInvoker);
+                Unit* caster = m_creature;
 
                 if (!target)
                     return;
 
-                if (param3 & CAST_INTURRUPT_PREVIOUS || !m_creature->IsNonMeleeSpellCasted(false))
+                //Cast is always triggered if target is forced to cast on self
+                if (param3 & CAST_FORCE_TARGET_SELF)
                 {
-                    m_creature->InterruptNonMeleeSpells(false);
+                    param3 |= CAST_TRIGGERED;
+                    caster = target;
+                }
+
+                //Interrupt any previous spell
+                if (caster->IsNonMeleeSpellCasted(false) && param3 & CAST_INTURRUPT_PREVIOUS)
+                    caster->InterruptNonMeleeSpells(false);
 
-                   const SpellEntry* tSpell = GetSpellStore()->LookupEntry(param1);
+                //Cast only if not casting or if spell is triggered
+                if (param3 & CAST_TRIGGERED || !caster->IsNonMeleeSpellCasted(false))
+                {
+                    const SpellEntry* tSpell = GetSpellStore()->LookupEntry(param1);
 
+                    //Verify that spell exists
                     if (tSpell)
                     {
-                        if ((param3 & CAST_FORCE_CAST) || CanCast(target, tSpell))
-                            m_creature->CastSpell(target, param1, (param3 & CAST_TRIGGERED));
+                        //Check if cannot cast spell
+                        if (!(param3 & (CAST_FORCE_TARGET_SELF | CAST_FORCE_CAST)) && 
+                            !CanCast(target, tSpell, (param3 & CAST_TRIGGERED)))
+                        {
+                            //Melee current victim if flag not set
+                            if (!(param3 & CAST_NO_MELEE_IF_OOM))
+                            {
+                                AttackDistance = 0;
+                                AttackAngle = 0;
+
+                                m_creature->GetMotionMaster()->Clear(false);
+                                m_creature->GetMotionMaster()->Mutate(new TargetedMovementGenerator<Creature>(*m_creature->getVictim(), AttackDistance, AttackAngle));
+                            }
+
+                        }else caster->CastSpell(target, param1, (param3 & CAST_TRIGGERED));
 
                     }else error_log("SD2: EventAI creature %d attempt to cast spell that doesn't exist %d", m_creature->GetCreatureInfo()->Entry, param1);
                 }
@@ -498,11 +553,16 @@ struct MANGOS_DLL_DECL Mob_EventAI : public ScriptedAI
 
         case ACTION_T_COMBAT_MOVEMENT:
             {
+                CombatMovementEnabled = param1;
+
                 //Allow movement (create new targeted movement gen if none exist already)
-                if (param1)
+                if (CombatMovementEnabled)
                 {
                     if (m_creature->GetMotionMaster()->top()->GetMovementGeneratorType() != TARGETED_MOTION_TYPE)
+                    {
+                        m_creature->GetMotionMaster()->Clear(false);
                         m_creature->GetMotionMaster()->Mutate(new TargetedMovementGenerator<Creature>(*m_creature->getVictim(), AttackDistance, AttackAngle));
+                    }
                 }
                 else
                     if (m_creature->GetMotionMaster()->top()->GetMovementGeneratorType() == TARGETED_MOTION_TYPE)
@@ -921,6 +981,8 @@ struct MANGOS_DLL_DECL Mob_EventAI : public ScriptedAI
                         case EVENT_T_TIMER_OOC_SINGLE:
                         case EVENT_T_MANA:
                         case EVENT_T_HP:
+                        case EVENT_T_TARGET_HP:
+                        case EVENT_T_TARGET_CASTING:
                             ProcessEvent(*i);
                             break;
                         }

scripts/creature/mob_event_ai.h

@@ -33,6 +33,8 @@ enum Event_Types
     EVENT_T_RANGE                   = 11,   //MinDist, MaxDist, TimeUnitlRepeat
     EVENT_T_OOC_LOS                 = 12,   //NoHostile, NoFriendly, TimeUntilRepeat
     EVENT_T_SPAWNED                 = 13,   //NONE
+    EVENT_T_TARGET_HP               = 14,   //HPMax%, HPMin%, TimeUntilRepeat
+    EVENT_T_TARGET_CASTING          = 15,   //TimeUntilRepeat
 
     EVENT_T_END,
 };
@@ -93,9 +95,11 @@ enum Target
 
 enum CastFlags
 {
-    CAST_INTURRUPT_PREVIOUS = 0x01,
-    CAST_TRIGGERED          = 0x02,
-    CAST_FORCE_CAST         = 0x04,
+    CAST_INTURRUPT_PREVIOUS     = 0x01,     //Interrupt any spell casting
+    CAST_TRIGGERED              = 0x02,     //Triggered (this makes spell cost zero mana and have no cast time)
+    CAST_FORCE_CAST             = 0x04,     //Forces cast even if creature is out of mana or out of range
+    CAST_NO_MELEE_IF_OOM        = 0x08,     //Prevents creature from entering melee if out of mana or out of range
+    CAST_FORCE_TARGET_SELF      = 0x10,     //Forces the target to cast this spell on itself
 };
 
 struct EventAI_Event

scripts/zone/coilfang_resevoir/serpent_shrine/boss_fathomlord_karathress.cpp

@@ -133,6 +133,9 @@ struct MANGOS_DLL_DECL boss_fathomlord_karathressAI : public ScriptedAI
 
     void GetAdvisors()
     {
+        if(!pInstance)
+            return;
+
         Advisors[0] = pInstance->GetData64(DATA_SHARKKIS);
         Advisors[1] = pInstance->GetData64(DATA_TIDALVESS);
         Advisors[3] = pInstance->GetData64(DATA_CARIBDIS);
@@ -306,32 +309,6 @@ struct MANGOS_DLL_DECL boss_fathomguard_sharkkisAI : public ScriptedAI
         }
     }
 
-    void MoveInLineOfSight(Unit *who)
-    {
-        if (!who || m_creature->getVictim())
-            return;
-
-        if (who->isTargetableForAttack() && who->isInAccessablePlaceFor(m_creature) && m_creature->IsHostileTo(who))
-        {
-            float attackRadius = m_creature->GetAttackDistance(who);
-            if (m_creature->IsWithinDistInMap(who, attackRadius) && m_creature->GetDistanceZ(who) <= CREATURE_Z_ATTACK_RANGE && m_creature->IsWithinLOSInMap(who))
-            {
-                if(who->HasStealthAura())
-                    who->RemoveSpellsCausingAura(SPELL_AURA_MOD_STEALTH);
-
-                DoStartAttackAndMovement(who);
-                if(!InCombat)
-                {
-                    if(pInstance)
-                    {
-                        pInstance->SetData64(DATA_KARATHRESSEVENT_STARTER, who->GetGUID());
-                        pInstance->SetData(DATA_KARATHRESSEVENT, 1);
-                    }
-                }
-            }
-        }
-    }
-
     void UpdateAI(const uint32 diff)
     {
         //Only if not incombat check if the event is started

scripts/zone/temple_of_ahnqiraj/boss_cthun.cpp

@@ -188,7 +188,8 @@ struct MANGOS_DLL_DECL eye_of_cthunAI : public Scripted_NoMovementAI
         m_creature->RemoveFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NOT_SELECTABLE | UNIT_FLAG_NOT_ATTACKABLE | UNIT_FLAG_ANIMATION_FROZEN);
 
         //Reset Phase
-        pInst->SetData(DATA_CTHUN_PHASE, 0);
+        if (pInst)
+            pInst->SetData(DATA_CTHUN_PHASE, 0);
     }
 
     void Aggro(Unit *who)
@@ -216,6 +217,10 @@ struct MANGOS_DLL_DECL eye_of_cthunAI : public Scripted_NoMovementAI
         if (!m_creature->SelectHostilTarget() || !m_creature->getVictim())
             return;
 
+        //No instance
+        if (!pInst)
+            return;
+
         switch (pInst->GetData(DATA_CTHUN_PHASE))
         {
 
@@ -384,6 +389,10 @@ struct MANGOS_DLL_DECL eye_of_cthunAI : public Scripted_NoMovementAI
 
     void DamageTaken(Unit *done_by, uint32 &damage) 
     {
+        //No instance
+        if (!pInst)
+            return;
+
         switch (pInst->GetData(DATA_CTHUN_PHASE))
         {
             case 0:
@@ -499,7 +508,8 @@ struct MANGOS_DLL_DECL cthunAI : public Scripted_NoMovementAI
         m_creature->RemoveAurasDueToSpell(SPELL_TRANSFORM);
         m_creature->SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NOT_SELECTABLE | UNIT_FLAG_NOT_ATTACKABLE);
 
-        pInst->SetData(DATA_CTHUN_PHASE, 0);
+        if (pInst)
+            pInst->SetData(DATA_CTHUN_PHASE, 0);
     }
 
     void Aggro(Unit *who)
@@ -611,6 +621,10 @@ struct MANGOS_DLL_DECL cthunAI : public Scripted_NoMovementAI
 
         m_creature->SetUInt64Value(UNIT_FIELD_TARGET, 0);
 
+        //No instance
+        if (!pInst)
+            return;
+
         switch (pInst->GetData(DATA_CTHUN_PHASE))
         {
             //Transition phase
@@ -893,6 +907,10 @@ struct MANGOS_DLL_DECL cthunAI : public Scripted_NoMovementAI
 
     void DamageTaken(Unit *done_by, uint32 &damage) 
     {
+        //No instance
+        if (!pInst)
+            return;
+
         switch (pInst->GetData(DATA_CTHUN_PHASE))
         {
             case 3: