Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to handle vocatives robustly #23

Open
genelkim opened this issue Apr 8, 2019 · 0 comments
Open

Need to handle vocatives robustly #23

genelkim opened this issue Apr 8, 2019 · 0 comments
Assignees

Comments

@genelkim
Copy link
Owner

genelkim commented Apr 8, 2019

In the example below, the verb conjugation is broken due to the vocative not being filtered before that process (or maybe our patterns just need to allow vocatives?)

| Failed Form: GENERATED
| Expected "My ill feelings towards you, Lex, are endless"
| but saw "My ill feelings towards you Lex be endless."
| EXPECTED => "My ill feelings towards you, Lex, are endless"
| GENERATED => "My ill feelings towards you Lex be endless."
| ULF => ((MY.D (N+PREDS (ILL.A (PLUR FEELING.N)) (TOWARDS.P-ARG YOU.PRO)))
(VOC |Lex|) ((PRES BE.V) ENDLESS.A))
|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants