Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: georust/polyline
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: refs/heads/structured_errors
Choose a base ref
...
head repository: georust/polyline
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 6 files changed
  • 2 contributors

Commits on May 11, 2024

  1. Switch to structured errors, inline encoding (#48)

    * Switch to structured errors, inline encoding
    
    * Simplify Display impl for error
    
    * Document error fields
    
    * Fix error message case according to convention
    urschrei authored May 11, 2024
    Configuration menu
    Copy the full SHA
    6872788 View commit details
    Browse the repository at this point in the history
  2. Skip intermediate coord representation (#49)

    We can just build up the coords directly rather than building up arrays
    and then converting them to Coords.
    
    ```
    $ cargo bench --bench="*" --  --baseline=sha-6872788
       Compiling polyline v0.10.2 (/Users/mkirk/src/georust/polyline)
        Finished `bench` profile [optimized] target(s) in 0.94s
         Running benches/benchmarks.rs
    (target/release/deps/benchmarks-8b91c88197106af3)
    encode 10_000 coordinates at precision 1e-5
                            time:   [180.56 µs 180.85 µs 181.16 µs]
                            change: [-1.3886% -1.0790% -0.7773%] (p = 0.00 < 0.05)
                            Change within noise threshold.
    Found 5 outliers among 100 measurements (5.00%)
      2 (2.00%) low mild
      3 (3.00%) high mild
    
    encode 10_000 coordinates at precision 1e-6
                            time:   [219.72 µs 220.82 µs 221.84 µs]
                            change: [+0.5301% +1.0508% +1.5979%] (p = 0.00 < 0.05)
                            Change within noise threshold.
    
    decode 10_000 coordinates at precision 1e-5
                            time:   [80.937 µs 81.828 µs 82.713 µs]
                            change: [-4.9284% -3.9764% -2.9753%] (p = 0.00 < 0.05)
                            Performance has improved.
    
    decode 10_000 coordinates at precision 1e-6
                            time:   [97.706 µs 98.786 µs 99.825 µs]
                            change: [-3.1947% -2.2649% -1.3617%] (p = 0.00 < 0.05)
                            Performance has improved.
    ```
    michaelkirk authored May 11, 2024
    Configuration menu
    Copy the full SHA
    b3a3c56 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Configuration menu
    Copy the full SHA
    694ca02 View commit details
    Browse the repository at this point in the history
  2. Update edition, metadata, README, dependencies (#51)

    * Update README, metadata, and edition
    
    * Update CHANGELOG.md
    
    Co-authored-by: Michael Kirk <[email protected]>
    
    ---------
    
    Co-authored-by: Michael Kirk <[email protected]>
    urschrei and michaelkirk authored May 13, 2024
    Configuration menu
    Copy the full SHA
    2b360f5 View commit details
    Browse the repository at this point in the history
  3. benchmarks against flexpolyline (#46)

    Co-authored-by: Stephan Hügel <[email protected]>
    michaelkirk and urschrei authored May 13, 2024
    Configuration menu
    Copy the full SHA
    bb76082 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    add9d0f View commit details
    Browse the repository at this point in the history
Loading