-
Notifications
You must be signed in to change notification settings - Fork 1
[FEATURE REQUEST] Add toggle for calling UPDATE_SUN, UPDATE_RCONST within integrator step #5
Comments
@RolfSander, thanks for this. I had removed those calls from the integrator files but this is an easy way to be able to toggle these calls. I'll add this into the next KPP update. |
After taking a closer look at these subroutines, I think that Update_SUN is probably never necessary. I guess it would be sufficient to use the ICNTRL(15) switch only for Update_RCONST:
|
Following Github issue github/KPP #5, we have re-added the calls to UPDATE_RCONST within all of the Fortran-90 integrators. These will only be activated if KPP input parameter ICNTRL(15) = 1. Normally for GEOS-Chem and other external models, we do the rate updates outside of KPP for computational expediency.
This is now done in commit e7540d3. All of the F90 integrator modules have this IF statement that can toggle UPDATE_RCONST if the user wishes. This will go into the next KPP version. I will close out this issue now. |
This commit follows Github issue geoschem/KPP #5. If the user sets the ICNTRL(15) slot to 1, then the routine Update_Rconst() will be called from within the Rosenbrock solver. Normally this option will be disabled. We will modify the other solver files accordingly, but the Rosenbrock solver is the only one used for GEOS-Chem, so we focus on this one first. Signed-off-by: Bob Yantosca <[email protected]>
My updates actually broke KPP so I went back to the GC_updates branch and started a new dev branch. In commit 342a4ac I added the call to Update_RCONST if It was more complex than I thought, I had to pass a logical flag with the value of |
Hmm, I didn't realize that this would be so complex. An alternative for a quick implementation in the other solvers might be to declare
as a module-wide variable, i.e., before the |
@RolfSander wrote:
The text was updated successfully, but these errors were encountered: