Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add encrypted backups card to connect alby account page #798

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Nov 14, 2024

Fixes #782

A temporary addition without a major redesign.

image

@rolznz rolznz requested review from reneaaron and bumi November 14, 2024 06:09
@@ -47,10 +47,19 @@ export function ConnectAlbyAccount({ connectUrl }: ConnectAlbyAccountProps) {
</CardDescription>
</CardHeader>
</Card>
<Card className="w-full">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only work for LDK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we do not know at startup if they will choose LDK, because this screen is shown before picking the backend type.

Copy link
Contributor Author

@rolznz rolznz Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to do this without a*

*Encrypted backups are only available for the Alby Hub embedded node. Read more. (guide link)

Thoughts? @bumi @reneaaron

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually thinking of adding some "security" page. Which describes all the details from the importance of the password, the seed, and also these backup options.
So we can link there and people have to acknowledge it similar to a ToS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bumi that sounds great. I think we also want to advertise backups as a feature worth having an Alby Account though, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will move your idea to a new issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think this change is good. I don't think we need the disclaimer here when we talk more about security and backups in detail and link to that.

@rolznz rolznz marked this pull request as draft November 27, 2024 02:47
<Card className="w-full">
<CardHeader className="flex flex-col justify-center items-center text-center p-4">
<LifeBuoy className="w-6 h-6" />
<CardTitle className="text-sm">Support</CardTitle>
<CardTitle className="text-sm">Real Support</CardTitle>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the word "real" here. is the other one "fake"? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I was thinking about chatbots. But I will undo this change.

@rolznz rolznz marked this pull request as ready for review December 3, 2024 01:32
@rolznz rolznz merged commit faf9063 into master Dec 3, 2024
9 checks passed
@rolznz rolznz deleted the feat/connect-alby-account-encrypted-backups branch December 3, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add encrypted backups benefit to ConnectAlbyAccount page
2 participants