-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add encrypted backups card to connect alby account page #798
Conversation
@@ -47,10 +47,19 @@ export function ConnectAlbyAccount({ connectUrl }: ConnectAlbyAccountProps) { | |||
</CardDescription> | |||
</CardHeader> | |||
</Card> | |||
<Card className="w-full"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will only work for LDK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we do not know at startup if they will choose LDK, because this screen is shown before picking the backend type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to do this without a*
*Encrypted backups are only available for the Alby Hub embedded node. Read more. (guide link)
Thoughts? @bumi @reneaaron
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually thinking of adding some "security" page. Which describes all the details from the importance of the password, the seed, and also these backup options.
So we can link there and people have to acknowledge it similar to a ToS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bumi that sounds great. I think we also want to advertise backups as a feature worth having an Alby Account though, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will move your idea to a new issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I think this change is good. I don't think we need the disclaimer here when we talk more about security and backups in detail and link to that.
<Card className="w-full"> | ||
<CardHeader className="flex flex-col justify-center items-center text-center p-4"> | ||
<LifeBuoy className="w-6 h-6" /> | ||
<CardTitle className="text-sm">Support</CardTitle> | ||
<CardTitle className="text-sm">Real Support</CardTitle> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the word "real" here. is the other one "fake"? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I was thinking about chatbots. But I will undo this change.
Fixes #782
A temporary addition without a major redesign.